From nobody Sun Sep 3 03:40:33 2023 X-Original-To: freebsd-stable@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RdcxC0ptZz4s2Br for ; Sun, 3 Sep 2023 03:40:47 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RdcxB69Fnz3gc0 for ; Sun, 3 Sep 2023 03:40:46 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-52a5c0d949eso391241a12.0 for ; Sat, 02 Sep 2023 20:40:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1693712444; x=1694317244; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=nj94eJuFapgwFcuv2O43EqPL0exKHeDNTYRB0qfZJuM=; b=Zk1e7TgWBa9wdBZbar5mrwDNXZ7t+FYNkp7EJ4kdX4bZCeKDRyEV14Z42PtvrmG0ZM jkuZoMHS2cmW7V60RyWIMTlP5OixDdhmLota4NTipb3PfuxX4nghJRp9sIexWYaPnqQx uUqJ3feFZpkkYHsqtfwnJA5uKnZO9tESkgM5/+Lk2Wea2aQcQqA6vSl+OmGhei6jNeaR OmAlEfIEecz0fX+cLGJn7H73XdwhunY+bYCLihS8mWaw6ZEWNxJ/3W8qvB8WgLs1M9nd SccZ4xuQIpxnBpzau2haEXN/DCKBqPncaa6c0BBVEcm8puHWGmbyn4+t5+KzYYhBQP4+ GN9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693712444; x=1694317244; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nj94eJuFapgwFcuv2O43EqPL0exKHeDNTYRB0qfZJuM=; b=GogqzoAYM+cpkEYQOyDAD7+LoCHikHHcpFG94Ilze2ruo3H7nQZsB59rdvKafWe3Dt FzTZ8AGnIlfCRH06KL0GwQ0nw1MFnuRHoxGLyKkp9eY4jUEXJq/an39v0MazWTinJfHk PPFwIh3xG1z7IyeqbwI/Tt7g19pKrdeplpZle4s4zdb27j0z2LElCi0O8Lxasb3bUfBr 5zHUZ+tnaRdThpVnSSjajvYYwAvH8m5pQFiKv0yOSQG9OtX92om21bK+kYhebVQlsTjc m7eOH4w/NzwHHAAUcPE1JCUBNLW4myNDjNhNKYQh4yEXasjWKz7vuwtaZKtQVLiXQ+1O zkyw== X-Gm-Message-State: AOJu0YyXGEsM87mJbwCzy2WOWODCzl394K+f99LFZTg0DbMxARZFpV1E bB/weZ8DPQc/TlNjHZlig8OrlaGn0iDyKYR5JQXVJg== X-Google-Smtp-Source: AGHT+IGLdnEQhInTV98dMfS7fY0thrTlldiZWwAjVCukzKM4HsZgPnnfGlenn7EW/U/ltsWqOB/De1HOO/s5BqDdEZY= X-Received: by 2002:a17:906:10dc:b0:9a1:ec3d:9004 with SMTP id v28-20020a17090610dc00b009a1ec3d9004mr5264541ejv.9.1693712444547; Sat, 02 Sep 2023 20:40:44 -0700 (PDT) List-Id: Production branch of FreeBSD source code List-Archive: https://lists.freebsd.org/archives/freebsd-stable List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org MIME-Version: 1.0 References: <20230903123028.4ffceb705824f86d2efc21e3@dec.sakura.ne.jp> In-Reply-To: From: Warner Losh Date: Sat, 2 Sep 2023 21:40:33 -0600 Message-ID: Subject: Re: Is there any plan for ZFS and timerfd updates on stable/14? To: Jake Freeland Cc: Tomoaki AOKI , FreeBSD-STABLE Mailing List Content-Type: multipart/alternative; boundary="0000000000009bf61206046c2822" X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Queue-Id: 4RdcxB69Fnz3gc0 --0000000000009bf61206046c2822 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Sep 2, 2023, 9:36 PM Jake Freeland wrote: > On Sat, Sep 2, 2023 at 10:31=E2=80=AFPM Tomoaki AOKI > wrote: > >> Hi. >> >> There are discussions about deadlocks issue of ZFS on freebsd-current >> ML, starting from [1] last month. >> IIRC, at least some fixes (candidates?) are merged to main, but not yet >> to stable/14. >> >> Upcoming (aleready released? or still rc3?) OpenZFS 2.2-release seems >> to have most of them. So my 1st question is "Is there any plan to >> import vendor/openzfs/zfs-2.2-release into stable/14 BEFORE BRANCHING >> releng/14? >> >> And one more. timerfd is added at last-minutes BEFORE stable/14 is >> branched, and already have not-yet-MFC'ed fixes [2], [3], [4] and >> Differential revision D41600 on Phablicator [5] related to memory leaks >> and locks. >> Additionally, splitting out lib32 part to proper place is proposed >> as D41640 [6]. Both [5] and [6] are accepted but not yet landed. >> Also, D41641 [7] proposes namespace pollution adjustments. This can be >> optional? >> >> Memory leaks and improper locks can lead system to security issues or >> deadlocks, so it would be benefical if landed and MFC'ed BEFORE >> releng/14 branches. >> >> Is there any plan to do so? At least, existing deadlocks should be >> considered as SHOW-STOPPER and resolved. >> > > The plan is to get all of those patches in before releng/14.0, I believe. > > What are your thoughts, Warner? > Sounds like the reviews are done or nearly so. I've not had time to look closely to be sure... I'd planned on making time Tuesday morning. Warner > Thanks, > Jake Freeland > > >> >> I myself am bitten by several deadlocks on poudriere full builds after >> upgrading base from stable/13 to stable/14, finally finished with >> increasing kern.maxvnodes after powercycle on each deadlock and >> continue. >> >> >> Thanks in advance! >> >> [1] >> https://lists.freebsd.org/archives/freebsd-current/2023-August/004162.ht= ml >> >> [2] >> >> https://cgit.freebsd.org/src/commit/?id=3D02f534b57f84d6f4f97c337b05b383= c8b3aaf18c >> >> [3] >> >> https://cgit.freebsd.org/src/commit/?id=3D5eab523053db79b4bd4f926c7d7ac0= 4444d9c1da >> >> [4] >> >> https://cgit.freebsd.org/src/commit/?id=3Df4296cfb409a48de00bfa60e76f686= c2b031876f >> >> [5] https://reviews.freebsd.org/D41600 >> >> [6] https://reviews.freebsd.org/D41640 >> >> [7] https://reviews.freebsd.org/D41641 >> >> -- >> Tomoaki AOKI >> >> --0000000000009bf61206046c2822 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Sat, Sep 2, 2023, 9:36 PM Jake Freeland <jake@technologyfriends.net> w= rote:
On Sat, Sep 2, 2023 at 10:31=E2=80=AFPM Tomoaki AOKI <juncho= on@dec.sakura.ne.jp> wrote:
Hi.

There are discussions about deadlocks issue of ZFS on freebsd-current
ML, starting from [1] last month.
IIRC, at least some fixes (candidates?) are merged to main, but not yet
to stable/14.

Upcoming (aleready released? or still rc3?) OpenZFS 2.2-release seems
to have most of them. So my 1st question is "Is there any plan to
import vendor/openzfs/zfs-2.2-release into stable/14 BEFORE BRANCHING
releng/14?

And one more. timerfd is added at last-minutes BEFORE stable/14 is
branched, and already have not-yet-MFC'ed fixes [2], [3], [4] and
Differential revision D41600 on Phablicator [5] related to memory leaks
and locks.
Additionally, splitting out lib32 part to proper place is proposed
as D41640 [6].=C2=A0 Both [5] and [6] are accepted but not yet landed.
Also, D41641 [7] proposes namespace pollution adjustments. This can be
optional?

Memory leaks and improper locks can lead system to security issues or
deadlocks, so it would be benefical if landed and MFC'ed BEFORE
releng/14 branches.

Is there any plan to do so? At least, existing deadlocks should be
considered as SHOW-STOPPER and resolved.

The plan is to get all of those patches in before releng/14.0, I believe.=

What are your=C2=A0thoughts, Warner?
<= /div>

Sounds like the reviews are done or nearly so. I've not had time to lo= ok closely to be sure... I'd planned on making time Tuesday morning.=C2= =A0

Warner


<= /div>
Thanks,
Jake Freeland
=C2=A0

I myself am bitten by several deadlocks on poudriere full builds after
upgrading base from stable/13 to stable/14, finally finished with
increasing kern.maxvnodes after powercycle on each deadlock and
continue.


Thanks in advance!

[1]
https://lists.f= reebsd.org/archives/freebsd-current/2023-August/004162.html

[2]
https:/= /cgit.freebsd.org/src/commit/?id=3D02f534b57f84d6f4f97c337b05b383c8b3aaf18c=

[3]
https:/= /cgit.freebsd.org/src/commit/?id=3D5eab523053db79b4bd4f926c7d7ac04444d9c1da=

[4]
https:/= /cgit.freebsd.org/src/commit/?id=3Df4296cfb409a48de00bfa60e76f686c2b031876f=

[5] https://reviews.freebsd.org/D41600

[6] https://reviews.freebsd.org/D41640

[7] https://reviews.freebsd.org/D41641

--
Tomoaki AOKI=C2=A0 =C2=A0 <junchoon@dec.sakura.ne.jp>

--0000000000009bf61206046c2822--