Date: Mon, 11 Jan 2021 21:04:15 -0700 From: Alan Somers <asomers@freebsd.org> To: Ryan Libby <rlibby@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 292808246db7 - main - ICMP checksum test: Fix for big endian Message-ID: <CAOtMX2gLemHjBNEbcJvZ3C9BYqdNV-KdtceCWcD-EwUW79x3Gw@mail.gmail.com> In-Reply-To: <CAHgpiFxBuXy7UdrxGjgB7uFDOM3Ld7VtA36Sg_eqCeY6RokXOA@mail.gmail.com> References: <202101120210.10C2ADmg048698@gitrepo.freebsd.org> <CAHgpiFxBuXy7UdrxGjgB7uFDOM3Ld7VtA36Sg_eqCeY6RokXOA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jan 11, 2021 at 8:25 PM Ryan Libby <rlibby@freebsd.org> wrote: > On Mon, Jan 11, 2021 at 6:10 PM Alan Somers <asomers@freebsd.org> wrote: > > > > The branch main has been updated by asomers: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=292808246db702b9194deb8938e40fd06914aea9 > > > > commit 292808246db702b9194deb8938e40fd06914aea9 > > Author: Charlie Root <renato.riolino@eldorado.org.br> > > Hmm, did your git client fill in the author name that way? Since... > > > AuthorDate: 2021-01-12 01:56:12 +0000 > > Commit: Alan Somers <asomers@FreeBSD.org> > > CommitDate: 2021-01-12 02:03:46 +0000 > > > > ICMP checksum test: Fix for big endian > > > > The in_cksum tests originally tried to simulate a BE environment by > > swapping the byte order of the input. But that's overcomplicated, > and > > didn't actually work on real BE hardware. The correct testing > strategy > > is just to test on the native endianness, and run the tests in both > BE > > and LE environments. > > > > Submitted by: Renato Riolino < > renato.riolino@eldorado.org.br> > > ...given this submitted-by line, I am guessing it wasn't intended? > > > Reviewed By: asomers > > MFC after: 2 weeks > > Differential Revision: https://reviews.freebsd.org/D23193 > > --- > Well, Renato opened the PR on Phabricator. When I pulled in his patch, phabricator must've helpfully pulled in the author line, too. But the "Submitted by" line I wrote by hand. -Alan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOtMX2gLemHjBNEbcJvZ3C9BYqdNV-KdtceCWcD-EwUW79x3Gw>