From owner-svn-ports-all@FreeBSD.ORG  Wed Oct 30 18:23:20 2013
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 29C03E98;
 Wed, 30 Oct 2013 18:23:20 +0000 (UTC)
 (envelope-from amdmi3@amdmi3.ru)
Received: from smtp.timeweb.ru (smtp.timeweb.ru [92.53.114.190])
 (using TLSv1 with cipher AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id D9496287A;
 Wed, 30 Oct 2013 18:23:19 +0000 (UTC)
Received: from [213.148.20.85] (helo=hive.panopticon)
 by smtp.timeweb.ru with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.76) (envelope-from <amdmi3@amdmi3.ru>)
 id 1VbaQH-0002os-AR; Wed, 30 Oct 2013 22:23:17 +0400
Received: from hades.panopticon (hades.panopticon [192.168.0.32])
 by hive.panopticon (Postfix) with ESMTP id 858633C0;
 Wed, 30 Oct 2013 22:23:16 +0400 (MSK)
Received: by hades.panopticon (Postfix, from userid 1000)
 id 747981CB; Wed, 30 Oct 2013 22:23:16 +0400 (MSK)
Date: Wed, 30 Oct 2013 22:23:16 +0400
From: Dmitry Marakasov <amdmi3@amdmi3.ru>
To: Alexey Dokuchaev <danfe@FreeBSD.org>
Subject: Re: svn commit: r332113 - head/textproc/uncrustify
Message-ID: <20131030182316.GA72837@hades.panopticon>
References: <201310301412.r9UECUeK002034@svn.freebsd.org>
 <20131030144153.GC34668@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20131030144153.GC34668@FreeBSD.org>
User-Agent: Mutt/1.5.22 (2013-10-16)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Oct 2013 18:23:20 -0000

* Alexey Dokuchaev (danfe@FreeBSD.org) wrote:

> > New Revision: 332113
> > URL: http://svnweb.freebsd.org/changeset/ports/332113
> > 
> > +OPTIONS_DEFINE=	DOCS
> > +OPTIONS_DEFAULT=DOCS
> 
> This last line is redundant.
> 
> > -	${MKDIR} ${DOCSDIR}
> > -	cd ${WRKSRC}/documentation && ${COPYTREE_SHARE} '*' ${DOCSDIR}
> > -.endif
> > +	cd ${WRKSRC}/documentation && ${COPYTREE_SHARE} '*' ${STAGEDIR}${DOCSDIR}/
> 
> Using dot (.) instead of '*' is preferred, see PH section 5.15.

Got it, thx. Will fix these in my ports in one go later.

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru    http://www.amdmi3.ru