From owner-cvs-all  Sat Sep 21 19:49:48 2002
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 0868B37B401; Sat, 21 Sep 2002 19:49:47 -0700 (PDT)
Received: from mail.chesapeake.net (chesapeake.net [205.130.220.14])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 3251043E4A; Sat, 21 Sep 2002 19:49:46 -0700 (PDT)
	(envelope-from jroberson@chesapeake.net)
Received: from localhost (jroberson@localhost)
	by mail.chesapeake.net (8.11.6/8.11.6) with ESMTP id g8M2ngX29259;
	Sat, 21 Sep 2002 22:49:42 -0400 (EDT)
	(envelope-from jroberson@chesapeake.net)
Date: Sat, 21 Sep 2002 22:49:42 -0400 (EDT)
From: Jeff Roberson <jroberson@chesapeake.net>
To: Bruce Evans <bde@zeta.org.au>
Cc: Robert Watson <rwatson@FreeBSD.org>,
	<cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org>
Subject: Re: cvs commit: src/sys/security/mac_biba mac_biba.c src/sys/security/mac_mls
         mac_mls.c
In-Reply-To: <20020922065517.R11613-100000@gamplex.bde.org>
Message-ID: <20020921224816.K43954-100000@mail.chesapeake.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Sun, 22 Sep 2002, Bruce Evans wrote:

> On Sat, 21 Sep 2002, Robert Watson wrote:
>
> > rwatson     2002/09/21 11:29:38 PDT
> >
> >   Modified files:
> >     sys/security/mac_biba mac_biba.c
> >     sys/security/mac_mls mac_mls.c
> >   Log:
> >   As INVARIANTS isn't supported for code that loads only as a kernel
> >   module and is not linked into the base system, two KASSERT's rotted.
> >   Fix them by fixing variable names.  It would be really nice if
>                                                            ^^^^ nasty
> >   opt_global.h was used when building modules as part of a buildkernel.
> >
> >   Obtained from:  TrustedBSD Project
> >   Sponsored by:   DARPA, Network Associates Laboratories
>
> Modules are bad enough without making ones that only work with 1 kernel.
>
> Bruce
>

What if we were to allow modules to build in KASSERTS that were only
enabled if the kernel they were loaded into supported it?  That seems like
the right solution here.

Jeff


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message