From owner-svn-src-all@FreeBSD.ORG Tue Dec 7 10:21:12 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ACB2C1065670; Tue, 7 Dec 2010 10:21:12 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (60.wheelsystems.com [83.12.187.60]) by mx1.freebsd.org (Postfix) with ESMTP id 1D21B8FC19; Tue, 7 Dec 2010 10:21:11 +0000 (UTC) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id D47F645C98; Tue, 7 Dec 2010 11:21:10 +0100 (CET) Received: from localhost (pdawidek.whl [10.0.1.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 25ECD45683; Tue, 7 Dec 2010 11:21:04 +0100 (CET) Date: Tue, 7 Dec 2010 11:21:04 +0100 From: Pawel Jakub Dawidek To: Ivan Voras Message-ID: <20101207102104.GD1700@garage.freebsd.pl> References: <201012061218.oB6CI3oW032770@svn.freebsd.org> <20101206184453.GA1936@garage.freebsd.pl> <20101206192238.GB1936@garage.freebsd.pl> <20101206195327.GD1936@garage.freebsd.pl> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="pQhZXvAqiZgbeUkD" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 9.0-CURRENT amd64 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-5.9 required=4.5 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.0.4 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r216230 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Dec 2010 10:21:12 -0000 --pQhZXvAqiZgbeUkD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 06, 2010 at 09:28:42PM +0100, Ivan Voras wrote: > But there are two reasons that I think are important, which resulted > in changing this: >=20 > 1) It is being used out of the original context in the mailing list > posts I've referenced - it was being used (and in a worse way, by > having a hacked zpool binary) for alignment like I did in the patch, > despite that the sectorsize wasn't changed. FreeBSD is not Solaris, really. ZFS has a lot of code that is not needed in FreeBSD. For example we don't need to partition raw disks and use partition, we can simply use raw disks (or any other GEOM provider), thanks to GEOM. I also think that Solaris needs a lot of work to support 4kB sectors. We don't. We are prepared for that for a long time now. As I said many times now, doing such a change in ZFS will of course work for you, but it doesn't solve the problem properly. It doesn't solve the problem for all the other disks consumers. If you want to use hacked zpool binary that's fine by me, but don't commit this. > 2) The solaris "big sector" project, described in > http://arc.opensolaris.org/caselog/PSARC/2008/769/final_spec.txt > basically blesses ZFS to work with big sectors, and states "ZFS can > automatically run on larger sector size disk after the label change > and I/O path change." Since the effect of having a larger sectorsize > will effectively be only the change in ashift, this is what I've done. Hmm, what kind of argument is that? Yes, ZFS can work with larger sectors just fine. I have many such installations where I use ZFS on top of 4kB GELI providers. What this sentence describe is simply that ZFS is 4kB-sector ready. What you did actually suggest that ZFS can work only with 512 byte sectors, so you need to change alignment internally, which is not true - there is no need to modify ZFS, because it can support disks with larger sectors. > > BTW. ZFS is no longer open-source if you didn't notice. >=20 > I have noticed but I don't understand how it affects FreeBSD. I would > like to discuss this sometime but unless you have some urgent > interpretation of this information, I think it's best to start another > thread about it. I'm just saying that discussing anything upstream is much harder now. PS. Do you know your change breaks all current ZFS installation if stripesize is defined for a provider? # zpool create tank ada0 (upgrade FreeBSD so that ada0 now reports 4kB stripesize) # zpool import tank cannot import 'tank': invalid vdev configuration So you change was not only poorly thought out and not reviewed, but also not even minimally tested. Before we go any further, back it out. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --pQhZXvAqiZgbeUkD Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkz+Co8ACgkQForvXbEpPzSdkwCdHw/l+2bJFHI/wp/lKJoOZHGc QCkAoKAClH+e7mmrTBpZ+iG4MigzviqE =2GlF -----END PGP SIGNATURE----- --pQhZXvAqiZgbeUkD--