From owner-freebsd-net  Wed Feb  7 18:31: 5 2001
Delivered-To: freebsd-net@freebsd.org
Received: from iguana.aciri.org (iguana.aciri.org [192.150.187.36])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2B52A37B401; Wed,  7 Feb 2001 18:30:48 -0800 (PST)
Received: (from rizzo@localhost)
	by iguana.aciri.org (8.11.1/8.11.1) id f182Uax06671;
	Wed, 7 Feb 2001 18:30:36 -0800 (PST)
	(envelope-from rizzo)
From: Luigi Rizzo <rizzo@aciri.org>
Message-Id: <200102080230.f182Uax06671@iguana.aciri.org>
Subject: Re: Fw: if_ed.c && BRIDGE
In-Reply-To: <00ec01c09175$3a0cea60$1f90c918@jehovah> from Bosko Milekic at "Feb 7, 2001  9:17: 3 pm"
To: bmilekic@technokratis.com (Bosko Milekic)
Date: Wed, 7 Feb 2001 18:30:35 -0800 (PST)
Cc: luigi@FreeBSD.ORG, richw@webcom.com, freebsd-net@FreeBSD.ORG
X-Mailer: ELM [version 2.4ME+ PL43 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-net@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

> Hi Luigi, -net:

just one thing, before posting details could you verify that the
problem still occurs with the code that is in -STABLE as of today ?

I have done a bunch of changes to this and related code over the
last couple of weeks, including testing on an "ed" card, and have
not seen any panic on that lately (i did manage to produce a panic
before some of these commits so i am not claiming that the problem
never existed).

	cheers
	luigi

>     There seems to be a problem with the BRIDGE-specific
> "optimization" in if_ed.c. What it does is avoid getting a packet from
> the card if bridge_in() says that we're going to drop it. However, the
> code is broken and something eventually leads to a page fault.
> Disactivating this portion of if_ed.c rids us of the problem, but
> doesn't "fix it" properly.
> 
>     Rich has some debugging information including, I believe, a crash
> dump. Rich, if you can please post that here (i.e. the backtraces and
> fault information) as I seemed to have lost it (grrrrr, sorry about
> that).
> 
>     I would rather not just disable the BRIDGE section of if_ed.c to
> "mask out" the problem.
> 
> Regards,
> Bosko.
> 
> Rich Wales wrote:
> 
> > Bosko --
> >
> > That "if_ed.c" patch you had me try (commenting out the
> packet-dropping
> > optimization) seems to be quite solid.  If you wanted to go ahead
> and
> > commit it into -STABLE . . . .
> >
> > Rich Wales         richw@webcom.com
> http://www.webcom.com/richw/
> >
> 
> 
> 
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-net" in the body of the message
> 



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message