From owner-freebsd-rc@FreeBSD.ORG Wed Nov 9 19:16:57 2005 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 106EB16A41F; Wed, 9 Nov 2005 19:16:57 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6B3D943D5A; Wed, 9 Nov 2005 19:16:54 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id jA9JGRr5009953; Wed, 9 Nov 2005 11:16:27 -0800 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id jA9JGQO0009952; Wed, 9 Nov 2005 11:16:26 -0800 Date: Wed, 9 Nov 2005 11:16:26 -0800 From: Brooks Davis To: Maksim Yevmenkin Message-ID: <20051109191626.GG12837@odin.ac.hmc.edu> References: <20051102190655.GA3961@odin.ac.hmc.edu> <436A6649.7000602@savvis.net> <20051103203217.GA30685@odin.ac.hmc.edu> <436BE02D.2020404@savvis.net> <20051107200040.GB29473@odin.ac.hmc.edu> <4370EAB4.8090000@savvis.net> <20051108201620.GD27091@odin.ac.hmc.edu> <43713B7D.7090405@savvis.net> <20051109063847.GB4605@comp.chem.msu.su> <43723223.3030802@savvis.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="3xoW37o/FfUZJwQG" Content-Disposition: inline In-Reply-To: <43723223.3030802@savvis.net> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu Cc: freebsd-bluetooth@freebsd.org, freebsd-rc@freebsd.org, Panagiotis Astithas Subject: Re: [RFC] rc.d integration for the bluetooth subsystem X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Nov 2005 19:16:57 -0000 --3xoW37o/FfUZJwQG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 09, 2005 at 09:30:11AM -0800, Maksim Yevmenkin wrote: > All, >=20 > >>i also removed offending { } in while loop stdin redirection. if this i= s=20 > > > >Thanks! The handling of {} seems to be one of gray corners in sh(1) > >syntax if it works as in the initial version of your script. Another > >one I've noticed is the case operator. Your line was like this: > > > > case $line in > > > >and it still worked for $line containing IFS chars. sh(1) seems > >to put double quotes aroung the word passed to case implicitly. > >While such things may seem to make sh(1) coding a tad easier, I'm > >afraid they shouldn't be relied upon. >=20 > ok, do we agree that >=20 > http://people.freebsd.org/~emax/bluetooth-rc-4.diff.txt >=20 > looks fine? i have added double quotes around variables in case=20 > statements. any other comments, suggestions, objections? Looks good to me. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --3xoW37o/FfUZJwQG Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFDcksJXY6L6fI4GtQRAu1vAJwI9dpAevBjTnUPmsAGssO7BFn2hwCfTUdT 2GJN/jRcIDBUvBDDJ4U7zK4= =bjUp -----END PGP SIGNATURE----- --3xoW37o/FfUZJwQG--