Date: Mon, 6 Jan 2003 17:04:05 -0800 From: Maxime Henrion <mux@freebsd.org> To: Nate Lawson <nate@root.org> Cc: current@freebsd.org, ryan beasley <ryanb@goddamnbastard.org> Subject: Re: if_dc.c locking patch Message-ID: <20030107010405.GB66404@elvis.mu.org> In-Reply-To: <Pine.BSF.4.21.0301061642240.12472-200000@root.org> References: <20030104074914.GS311@goddamnbastard.org> <Pine.BSF.4.21.0301061642240.12472-200000@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Nate Lawson wrote: > Attached is a diff that fixes a "could sleep" problem where > ether_ifattach() does a malloc and dc(4) is holding a lock in its softc. > It uses a cleaner exit strategy with only one call to DC_UNLOCK and no > multiple return statements as well as fixing one place where "error" > wasn't set. If people are ok with it, I'll sweep other drivers that have > a similar problem. Doing this would maybe be a bit premature. A lot of drivers have FOO_LOCK and FOO_UNLOCK macros set to nothing, because of similar problems you're trying to fix. Interface locking probably needs to be rethought. Cheers, Maxime To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030107010405.GB66404>