From owner-svn-src-vendor@freebsd.org Thu Oct 15 15:41:10 2015 Return-Path: Delivered-To: svn-src-vendor@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C6D70A15684; Thu, 15 Oct 2015 15:41:10 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-qk0-x235.google.com (mail-qk0-x235.google.com [IPv6:2607:f8b0:400d:c09::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5F0B31CDE; Thu, 15 Oct 2015 15:41:07 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: by qkas79 with SMTP id s79so40673099qka.0; Thu, 15 Oct 2015 08:41:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=KkR5hMPZ4NV5lAb9UjLHdvYoH+Axy7zKlbzrhUo2Wj8=; b=cozQg4vgjX33ezSQl5lsxraf/Nm087kbzOAamH4agRji3gKZbF6hUP7y3JkVS4dg6n 9NKdVrsORXcGM4DZNJUYj2vgBUfuir5sDd65H14Jqu7vYFqFJPQjg1nEQVtPmfxooB+T cCXc4Zmw7yy9nTw6UbRy++0Oi8g0zlbruGXrhV++oeVFefccPwft4nDCMhghn9WXnNnF o6A2Q9JFSP1svvDsneC1MJU/UVkbOgjcyYqbPn8t15x7CDdNyHItHqeM5jRvjAFUSOqy Q6vmqLBHwSMS4GFcb44dCaInHYvMQeRVgi6Siyor8DihalHUlsxYBpQxGNNYYrHAxil0 3jBg== X-Received: by 10.194.11.71 with SMTP id o7mr11514434wjb.75.1444923666389; Thu, 15 Oct 2015 08:41:06 -0700 (PDT) Received: from mavbook.mavhome.dp.ua ([2a01:d0:c0a9:3:c685:8ff:fe11:1aa2]) by smtp.googlemail.com with ESMTPSA id i10sm17163361wjz.41.2015.10.15.08.41.05 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Oct 2015 08:41:05 -0700 (PDT) Sender: Alexander Motin Message-ID: <561FC90F.4090706@FreeBSD.org> Date: Thu, 15 Oct 2015 18:41:03 +0300 From: Alexander Motin User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Andriy Gapon , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-vendor@FreeBSD.org Subject: Re: svn commit: r289310 - vendor-sys/illumos/dist/common/zfs vendor-sys/illumos/dist/uts/common vendor-sys/illumos/dist/uts/common/crypto vendor-sys/illumos/dist/uts/common/crypto/io vendor-sys/illumos... References: <201510141112.t9EBCmFZ022230@repo.freebsd.org> <561FC5A0.3040909@FreeBSD.org> In-Reply-To: <561FC5A0.3040909@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-vendor@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the vendor work area tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Oct 2015 15:41:11 -0000 On 15.10.2015 18:26, Andriy Gapon wrote: > On 14/10/2015 13:12, Alexander Motin wrote: >> Author: mav >> Date: Wed Oct 14 11:12:47 2015 >> New Revision: 289310 >> URL: https://svnweb.freebsd.org/changeset/base/289310 >> >> Log: >> 4185 add new cryptographic checksums to ZFS: SHA-512, Skein, Edon-R >> >> Reviewed by: George Wilson >> Reviewed by: Prakash Surya >> Reviewed by: Saso Kiselkov >> Reviewed by: Richard Lowe >> Approved by: Garrett D'Amore >> Author: Matthew Ahrens >> >> illumos/illumos-gate@45818ee124adeaaf947698996b4f4c722afc6d1f >> >> Added: >> vendor/illumos/dist/common/crypto/ >> vendor/illumos/dist/common/crypto/edonr/ >> vendor/illumos/dist/common/crypto/edonr/edonr.c (contents, props changed) >> vendor/illumos/dist/common/crypto/edonr/edonr_byteorder.h (contents, props changed) >> vendor/illumos/dist/common/crypto/skein/ >> vendor/illumos/dist/common/crypto/skein/THIRDPARTYLICENSE (contents, props changed) >> vendor/illumos/dist/common/crypto/skein/THIRDPARTYLICENSE.descrip (contents, props changed) >> vendor/illumos/dist/common/crypto/skein/skein.c (contents, props changed) >> vendor/illumos/dist/common/crypto/skein/skein_block.c (contents, props changed) >> vendor/illumos/dist/common/crypto/skein/skein_impl.h (contents, props changed) >> vendor/illumos/dist/common/crypto/skein/skein_iv.c (contents, props changed) >> vendor/illumos/dist/common/crypto/skein/skein_port.h (contents, props changed) > > It seems that these are pieces of code that can be used by both the > userland and the kernel. I think that previously we used to import such > code into illumos-sys and then integrate it into sys/cddl (e.g. > common/zfs/). Perhaps it is worthwhile following that convention in > this case as well? I haven't decided what to do with this specific case. As I understand, now we are using FreeBSD's native crypto code instead of illumos' one. I was thinking about importing this commit only in infrastructural parts, until respective algorithms are implemented in our native crypto. I think it should not be a problem for Skein, since according to comments it is in public domain. About Edon-R I am not sure, since it seems to be CDDL. -- Alexander Motin