From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Oct 25 05:40:09 2010 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 38D5E1065673 for ; Mon, 25 Oct 2010 05:40:09 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 10C6E8FC17 for ; Mon, 25 Oct 2010 05:40:09 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o9P5e850015633 for ; Mon, 25 Oct 2010 05:40:08 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o9P5e8HE015632; Mon, 25 Oct 2010 05:40:08 GMT (envelope-from gnats) Resent-Date: Mon, 25 Oct 2010 05:40:08 GMT Resent-Message-Id: <201010250540.o9P5e8HE015632@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Alex Deiter Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E5B3C106564A for ; Mon, 25 Oct 2010 05:30:23 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id D3D548FC16 for ; Mon, 25 Oct 2010 05:30:23 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o9P5UNAu092524 for ; Mon, 25 Oct 2010 05:30:23 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id o9P5UNXq092523; Mon, 25 Oct 2010 05:30:23 GMT (envelope-from nobody) Message-Id: <201010250530.o9P5UNXq092523@www.freebsd.org> Date: Mon, 25 Oct 2010 05:30:23 GMT From: Alex Deiter To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/151709: [path] tomcat6 rc.d script status command X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Oct 2010 05:40:09 -0000 >Number: 151709 >Category: ports >Synopsis: [path] tomcat6 rc.d script status command >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Oct 25 05:40:08 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Alex Deiter >Release: 8.1-RELEASE >Organization: N/A >Environment: FreeBSD x4150b.tdc 8.1-RELEASE FreeBSD 8.1-RELEASE #0: Mon Jul 19 02:36:49 UTC 2010 root@mason.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64 >Description: Hi, status/poll command don't work for www/tomcat6: # /usr/local/etc/rc.d/tomcat6 start Starting tomcat60. # /usr/local/etc/rc.d/tomcat6 status ==>no any output here <== # /usr/local/etc/rc.d/tomcat6 poll ==>no any output here <== ^C # /usr/local/etc/rc.d/tomcat6 stop Stopping tomcat60. Waiting (max 60 secs) for PIDS: 73398. Please review small patch for rc.d script. >How-To-Repeat: cd /usr/ports/www/tomcat6 && make install >Fix: Please review small patch for rc.d script: # /usr/local/etc/rc.d/tomcat6 start Starting tomcat60. # /usr/local/etc/rc.d/tomcat6 status tomcat60 is running as pid 75572. # /usr/local/etc/rc.d/tomcat6 poll Waiting for PIDS: 75572, 75572, 75572, 75572^C # /usr/local/etc/rc.d/tomcat6 stop Stopping tomcat60. Waiting (max 60 secs) for PIDS: 75572. Patch attached with submission follows: --- www/tomcat6/files/tomcat6.sh.in.orig 2010-10-25 08:50:37.000000000 +0000 +++ www/tomcat6/files/tomcat6.sh.in 2010-10-25 09:28:07.000000000 +0000 @@ -145,14 +145,21 @@ echo "${name} not running? (check $pidfile)." return 1 fi + echo "${name} is running as pid ${rc_pid}." } tomcat_poll() { + _prefix= while (true) ; do rc_pid=$(tomcat_check_pidfile $pidfile) [ -z "$rc_pid" ] && break + echo -n ${_prefix:-"Waiting for PIDS: "}$rc_pid + _prefix=", " sleep 2 done + if [ -n "$_prefix" ]; then + echo "." + fi } tomcat_check_pidfile() { >Release-Note: >Audit-Trail: >Unformatted: