From owner-svn-ports-all@freebsd.org Thu Mar 7 14:37:10 2019 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 77951153128A; Thu, 7 Mar 2019 14:37:10 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1DF1C88B42; Thu, 7 Mar 2019 14:37:10 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id A5025D9A9; Thu, 7 Mar 2019 14:37:09 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-lj1-f178.google.com with SMTP id z25so14435180ljk.8; Thu, 07 Mar 2019 06:37:09 -0800 (PST) X-Gm-Message-State: APjAAAW68I8qOawiFwxcvjrX7tZppuYRhKCCi1CwAkwE8BGQ3q2kaaOG wNkG5CTyIG20fksStXttF8qhKBsWfguh2Z5rD3k= X-Google-Smtp-Source: APXvYqwd/FYuncPerHxGozdibU0TVSpoQOe1i9f5Ya1HTC1xb0NMVA27OGsYqqX+j8Kjc1PRVyxpmAWbVHVyf2ZjcZ8= X-Received: by 2002:a2e:9ec2:: with SMTP id h2mr5897379ljk.186.1551969428358; Thu, 07 Mar 2019 06:37:08 -0800 (PST) MIME-Version: 1.0 References: <201903071345.x27Dj4Gv030049@repo.freebsd.org> <20190307135631.GA68662@FreeBSD.org> In-Reply-To: <20190307135631.GA68662@FreeBSD.org> From: Kyle Evans Date: Thu, 7 Mar 2019 08:36:25 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r494945 - in head/comms/wsjtx: . files To: Alexey Dokuchaev Cc: Diane Bruce , svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 1DF1C88B42 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.89 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.89)[-0.893,0] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Mar 2019 14:37:10 -0000 On Thu, Mar 7, 2019 at 7:56 AM Alexey Dokuchaev wrote: > > On Thu, Mar 07, 2019 at 01:45:04PM +0000, Diane Bruce wrote: > [... snip ...] > > Added: > > head/comms/wsjtx/files/hamlib.patch (contents, props changed) > > head/comms/wsjtx/files/wsjtx.patch (contents, props changed) > > ... > > +post-patch: > > + ${CP} ${FILESDIR}/wsjtx.patch ${WRKSRC} > > + ${CP} ${FILESDIR}/hamlib.patch ${WRKSRC} > > Can't these be converted to normal patch-* files? > This situation is actually a little annoying- patches of these names exist in the distfile that are 0-length and applied by the wsjtx build (at some point? I didn't check the exact timing -- perhaps during config). Doing it this way serves dual purpose: 1.) It works around a bug in our patch that doesn't like 0-length patches, and 2.) It allows the patch to happen in the build's normal workflow. #1 being the more important one, to which this is a fairly clean solution. I've changed the behavior in head to match GNU patch behavior, but it's not likely worth an EN. Thanks, Kyle Evans