From nobody Fri Jan 16 19:55:23 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dt9Z40yWpz6NnJS for ; Fri, 16 Jan 2026 19:55:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dt9Z36G5Hz3SLq for ; Fri, 16 Jan 2026 19:55:23 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768593323; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Cx/1b9VSUIMTb7ab9A0qFIQwdyqfpTDlu7KgrbanROg=; b=JZwTu280JX9AwvxC89q9LwvWElQk2HWCwg3yysW805KHkoiVFdpkZ/vpVVvp3GsJNrcS/0 BScbxdbq4fwcElvrEsN/yi69RTOxk62TjGUzkshJPrhTmeJtwF0IiUuXNixohVkkU74XF1 DcikJYY6ao+PkT+xpZPdS25QbY/adnFHcj4dKGmWXabFVD9NBWblUHLV1hBfYbl8zexEuq y1zMoNcXcApOEjEyY8pQ3JA6g6uDL8GYpJvbqT9PKgK60NpRm3vpz1qWrbJXkbbr6KBa99 enhR8fUMlXPoCeDSgHQF2oWKJ7C9AGTkL1+jMBBStoDQGbfaep2mbMUnZFoBmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768593323; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Cx/1b9VSUIMTb7ab9A0qFIQwdyqfpTDlu7KgrbanROg=; b=ayc+UQmJFx/sD8FT6Qj+RescmkarqjjRI8uB3ZXZcYxgYAjvrQuXRDWLonRbKr+mAE/YCm Rs3sOW9+Ng8jLv/CbHMD0flsk7dBA75tzbQvwMxQeNhEJNBx5uOOqRk5djSrai1F7g2CKU LyVqTlbgYAU8GiukhsR6dhQUi85jEHmlHlPDJZ2dAzc2WacFEvmdpUotEDqxhWfpXHkyau eXmlbVEZhPQp1qjV1ySMx1g0AO52iaMw8UbC3vMZMX0VjjhaIm3JfhkVkFvzV5tSvU3Dtp DE1j/sRjXHAIB5bU3fds/uTezewm1/4Tcei73QKGb+aZ9mvWtToJ0pq0izraPQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1768593323; a=rsa-sha256; cv=none; b=FEJ9R+xr+IMxV5m7GHTURw2Se0SojepgW1whC7FwxVCgdpHEGykUJYmno9d/7z15d26JAW 3qxwnk/+pgZKAyqOqPkLDm151AOWuZGaWOb60o152p/2zB646rDwTtq53hmdz9rpWL4uAk VyxJ4/nF3nAcxx2fVIDqz1ilUueelKHl3wcK1llhyi5pNLnnog5C9xOvaZHvyWz6bSWUhY bN1T11gIx4MMAlnKLJ6Mr/Hjvn3FpdNy6Zt4sHQ7VlRn86w9lo7iG1o4aYsjWkbsfALSI0 Gn81+x7LCwdvCJwQEyl86rWDJJWXhrtLW4r7V7fTZj+osnAGwBk/dNzzcddMaw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dt9Z35JrDzCtW for ; Fri, 16 Jan 2026 19:55:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id e358 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 16 Jan 2026 19:55:23 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 75c591b26723 - main - smartpqi: Avoid declaring extern inline functions List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 75c591b26723711d7a38f2a5df7aecc28198cd83 Auto-Submitted: auto-generated Date: Fri, 16 Jan 2026 19:55:23 +0000 Message-Id: <696a97ab.e358.3e17cdba@gitrepo.freebsd.org> The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=75c591b26723711d7a38f2a5df7aecc28198cd83 commit 75c591b26723711d7a38f2a5df7aecc28198cd83 Author: Mark Johnston AuthorDate: 2026-01-16 19:49:22 +0000 Commit: Mark Johnston CommitDate: 2026-01-16 19:55:08 +0000 smartpqi: Avoid declaring extern inline functions Each C file is compiled separately so these functions can't be inlined except in the file where they are defined. Since these functions aren't used outside smartpqi_request.c, just do the simple thing and make them private to that file. Reported by: gcc Reviewed by: jrhall Fixes: c558eca47970 ("smartpqi: update to version 4660.0.2002") Differential Revision: https://reviews.freebsd.org/D54732 --- sys/dev/smartpqi/smartpqi_prototypes.h | 4 ---- sys/dev/smartpqi/smartpqi_request.c | 4 ++-- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/sys/dev/smartpqi/smartpqi_prototypes.h b/sys/dev/smartpqi/smartpqi_prototypes.h index f2eb328b6bc1..fdf69e38fa59 100644 --- a/sys/dev/smartpqi/smartpqi_prototypes.h +++ b/sys/dev/smartpqi/smartpqi_prototypes.h @@ -167,10 +167,6 @@ int pqisrc_send_tmf(pqisrc_softstate_t *, pqi_scsi_dev_t const *, rcb_t *, rcb_t *, int); int pqisrc_write_current_time_to_host_wellness(pqisrc_softstate_t *softs); int pqisrc_write_driver_version_to_host_wellness(pqisrc_softstate_t *softs); -extern inline void pqisrc_aio_build_cdb(aio_req_locator_t *, uint32_t, - rcb_t *, uint8_t *); -extern inline boolean_t pqisrc_aio_req_too_big(pqisrc_softstate_t *, pqi_scsi_dev_t *, - rcb_t const *, aio_req_locator_t *, uint32_t); void pqisrc_build_aio_common(pqisrc_softstate_t *, pqi_aio_req_t *, rcb_t *, uint32_t); void pqisrc_build_aio_R1_write(pqisrc_softstate_t *, diff --git a/sys/dev/smartpqi/smartpqi_request.c b/sys/dev/smartpqi/smartpqi_request.c index 3929a727c270..e6ba41a814b2 100644 --- a/sys/dev/smartpqi/smartpqi_request.c +++ b/sys/dev/smartpqi/smartpqi_request.c @@ -1492,7 +1492,7 @@ pqisrc_handle_blk_size_diffs(aio_req_locator_t *l) * handle based on dev type, Raid level, and encryption status. * TODO: make limits dynamic when this becomes possible. */ -inline boolean_t +static boolean_t pqisrc_aio_req_too_big(pqisrc_softstate_t *softs, pqi_scsi_dev_t *device, rcb_t const *rcb, aio_req_locator_t *l, uint32_t disk_blk_cnt) @@ -1636,7 +1636,7 @@ pqisrc_aio_show_locator_info(pqisrc_softstate_t *softs, } /* build the aio cdb */ -inline void +static void pqisrc_aio_build_cdb(aio_req_locator_t *l, uint32_t disk_blk_cnt, rcb_t *rcb, uint8_t *cdb) {