Date: Tue, 24 Dec 2013 10:17:52 -0500 From: John Baldwin <jhb@freebsd.org> To: Roger Pau Monne <roger.pau@citrix.com> Cc: xen-devel@lists.xen.org, julien.grall@citrix.com, freebsd-xen@freebsd.org, freebsd-current@freebsd.org, kib@freebsd.org, gibbs@freebsd.org Subject: Re: [PATCH v7 06/19] xen: implement an early timer for Xen PVH Message-ID: <201312241017.52700.jhb@freebsd.org> In-Reply-To: <1387479296-33389-7-git-send-email-roger.pau@citrix.com> References: <1387479296-33389-1-git-send-email-roger.pau@citrix.com> <1387479296-33389-7-git-send-email-roger.pau@citrix.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday, December 19, 2013 1:54:43 pm Roger Pau Monne wrote:
> When running as a PVH guest, there's no emulated i8254, so we need to
> use the Xen PV timer as the early source for DELAY. This change allows
> for different implementations of the early DELAY function and
> implements a Xen variant for it.
This mostly looks good to me. I would perhaps move DELAY() itself into
delay.c if it isn't too ugly to do so. I guess it would look something
like:
#if !(defined(__i386__) && defined(XEN))
void
DELAY(int n)
{
if (delay_tc(n))
return;
#ifdef __amd64__
init_ops.early_delay(n);
#else
i8254_delay(n);
}
#endif
This would let you leave delay_tc() private to delay.c.
--
John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201312241017.52700.jhb>