From nobody Fri Aug 7 13:08:23 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hGkws3JNcz6n3V2 for ; Fri, 07 Aug 2026 13:08:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hGkws19Mgz49m5 for ; Fri, 07 Aug 2026 13:08:29 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786108109; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=H3cKHQ26/z1mM5eLBqjIa8fTSBxnDDaRD+7wqmf0450=; b=Os1AQH6ScPt7V2Q3ajIUUf+Vfnuophv1S/Urs/RuInWNJU0AXIoRTXXS0T7Wc+U3D71dWW 6HPYYsAuKCm7jKhUKK2gzQYbKiJpc4Z7XriBymKhKUk+K0E4Gb0UVya3uuR/yh4SiPxmox /Fg0tLdn9qljW8ye9Y16BPXHPaeWhUqqG6JH26VarurQfeBFuRhZz0/ADa8avHsnmWPz+C UogB0qCNzeyT5cqlYp7LOFTtW2b2oeny5rjqBdWg3eR/PTG+z1sskbqu/PF7Gh/nZuLBKQ 6vpwM2rBfKIb4QcAW2Dh+5y68EcTGeD2TwlaFhX9FIoHdGmNMIRYuFC5n5RUbg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786108109; a=rsa-sha256; cv=none; b=Ez0qEcHTA2MWuY32aTtvI0IbRyEEMYdj+i0bbigiojE7FQQM95kJU0XgcIpnqMjecAdi5m g3eNwlJqVYPkGU/EKOzxcy5FaDfR9oMapXkC24hByG+R5VD3bu/Gqbdqzk7d0VcSVha30R MgpDpqWn1HwKgDj7YRx50+uZ/m2R7CfqehMk3nmWAyqboHRTDzcsUUIFtKpmrinj4Uue18 hgJUMPCmDJjNSSHVlLAclYLQ6GuwF8egHu8m0yZjT3yIByBpsfEIGvO3qt01zWG3lKxEmJ CsDfvmcK3BXZoEqbCniBESxr1xoVv8LLn344bJqs7jyJTzVI5TM3Dp55cucJOw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786108109; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=H3cKHQ26/z1mM5eLBqjIa8fTSBxnDDaRD+7wqmf0450=; b=Cfg5b3KCCH+vvuACSsTRb7+0O9aIKi35HEaofVDl5pm62uRTgVkO3krC2+AHEeurFMr2Dv aMWgUu1ZuKUfjHuLl730BUHHts4l2TwtEpVDgHwJfmPKseoJmf+hARUPlqZdlA87DdZkT9 XAC5Ds3puWVydu2BQmLu8QTkIAB/X/LDtNYfAEuIh72eXsJIbGGnsWE5YqxlEvuOEVAAdl bL4Y1mwb3nvuNIINxgt6WB9Mu+ttl65uVDbeKBuIhEJh7AoVsRzV606G1zLT3WasdGnt93 FQrupTHxSeFoAIIqS0/NHA1poCxQ61eJjRORrMveQ+Mhm60D5ZRr/9Fx17z9pA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hGkwr6Jznz17fP for ; Fri, 07 Aug 2026 13:08:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3cf85 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 07 Aug 2026 13:08:23 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Kajetan Puchalski From: Jessica Clarke Subject: git: a554906ea44c - main - bhyve: rtc_pl031: Fix PeriphID and CellID values List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jrtc27 X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: a554906ea44c26925730a25263e64890d48d2b36 Auto-Submitted: auto-generated Date: Fri, 07 Aug 2026 13:08:23 +0000 Message-Id: <6a75d8c7.3cf85.1cdaf8d7@gitrepo.freebsd.org> The branch main has been updated by jrtc27: URL: https://cgit.FreeBSD.org/src/commit/?id=a554906ea44c26925730a25263e64890d48d2b36 commit a554906ea44c26925730a25263e64890d48d2b36 Author: Kajetan Puchalski AuthorDate: 2026-08-07 11:57:02 +0000 Commit: Jessica Clarke CommitDate: 2026-08-07 13:04:30 +0000 bhyve: rtc_pl031: Fix PeriphID and CellID values PeriphID and CellID values are determined by macros which take an index. They currently receive a bus offset which has a stride of 4 bytes. This causes the ID1-3 registers to report incorrect values. Scale the offset before passing it to the macro to fix this. Tested with kvm-unit-tests/arm/pl031. Signed-off-by: Kajetan Puchalski Reviewed by: jrtc27 Fixes: 014d7082a239 ("bhyve: Implement a PL031 RTC on arm64") MFC after: 1 week Pull Request: https://github.com/freebsd/freebsd-src/pull/2358 Closes: https://github.com/freebsd/freebsd-src/pull/2358 --- usr.sbin/bhyve/rtc_pl031.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/usr.sbin/bhyve/rtc_pl031.c b/usr.sbin/bhyve/rtc_pl031.c index e334de6f92bb..74d392e5c023 100644 --- a/usr.sbin/bhyve/rtc_pl031.c +++ b/usr.sbin/bhyve/rtc_pl031.c @@ -236,13 +236,13 @@ rtc_pl031_read(struct rtc_pl031_softc *sc, int offset) case RTCPeriphID1: case RTCPeriphID2: case RTCPeriphID3: - reg = RTCPeriphID_VAL(offset - RTCPeriphID0); + reg = RTCPeriphID_VAL((offset - RTCPeriphID0) >> 2); break; case RTCCellID0: case RTCCellID1: case RTCCellID2: case RTCCellID3: - reg = RTCCellID_VAL(offset - RTCCellID0); + reg = RTCCellID_VAL((offset - RTCCellID0) >> 2); break; default: /* Return 0 in reads from unasigned registers */