From owner-freebsd-bugs  Fri Dec  4 01:39:23 1998
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id BAA12923
          for freebsd-bugs-outgoing; Fri, 4 Dec 1998 01:39:23 -0800 (PST)
          (envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id BAA12908
          for <freebsd-bugs@FreeBSD.org>; Fri, 4 Dec 1998 01:39:21 -0800 (PST)
          (envelope-from gnats@FreeBSD.org)
Received: (from Unknown UID 563@localhost)
	by freefall.freebsd.org (8.8.8/8.8.5) id BAA08061;
	Fri, 4 Dec 1998 01:40:01 -0800 (PST)
Received: from bd.mbn.or.jp (bd.mbn.or.jp [202.217.0.43])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id BAA12466
          for <FreeBSD-gnats-submit@freebsd.org>; Fri, 4 Dec 1998 01:32:56 -0800 (PST)
          (envelope-from chi@bd.mbn.or.jp)
Received: from chino.localhost (cse5-34.sapporo.mbn.or.jp [202.217.111.58])
	by bd.mbn.or.jp (8.9.1/bd.mbn.or.jp-2.0) with ESMTP id SAA07552
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 4 Dec 1998 18:32:30 +0900 (JST)
Message-Id: <199812040932.SAA07552@bd.mbn.or.jp>
Date: Fri, 4 Dec 1998 18:32:30 +0900 (JST)
From: chi@bd.mbn.or.jp
Reply-To: chi@bd.mbn.or.jp
To: FreeBSD-gnats-submit@FreeBSD.ORG
X-Send-Pr-Version: 3.2
Subject: kern/8960: lnc driver does not set IFF_MULTICAST 
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         8960
>Category:       kern
>Synopsis:       lnc driver does not set IFF_MULTICAST
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:
>Keywords:
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Dec  4 01:40:01 PST 1998
>Last-Modified:
>Originator:     Chiharu Shibata
>Organization:
Japan FreeBSD Users Group
>Release:        FreeBSD 2.2.6-RELEASE i386
>Environment:

	all AMD PCnet based LAN board(lnc driver)

>Description:

	The lnc driver does not set IFF_MULTICAST flag
	even if "LNC_MULTICAST" is defined in /sys/i386/isa/if_lnc.c.

>How-To-Repeat:

	(1) Uncomment "#define LNC_MULTICAST" in /sys/i386/isa/if_lnc.c
	    or add "options LNC_MULTICAST" in kernel conf file.
	(2) Re-configure new kernel and boot.
	(3) Type "ifconfig -a".
	    >lnc0: flags=843<UP,BROADCAST,RUNNING,SIMPLEX> mtu 1500

	    This should be the following.
	    >lnc0: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> mtu 1500

>Fix:
	
--- if_lnc.c.orig	Thu Dec  3 15:50:12 1998
+++ if_lnc.c	Thu Dec  3 15:50:41 1998
@@ -69,6 +69,11 @@
 /* Some defines that should really be in generic locations */
 #define FCS_LEN 4
 #define MULTICAST_FILTER_LEN 8
+#ifdef LNC_MULTICAST
+#define LNC_IFF_DEFAULT (IFF_BROADCAST | IFF_SIMPLEX | IFF_MULTICAST)
+#else
+#define LNC_IFF_DEFAULT (IFF_BROADCAST | IFF_SIMPLEX)
+#endif
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -1272,7 +1277,7 @@
 	sc->arpcom.ac_if.if_name = lncdriver.name;
 	sc->arpcom.ac_if.if_unit = unit;
 	sc->arpcom.ac_if.if_mtu = ETHERMTU;
-	sc->arpcom.ac_if.if_flags = IFF_BROADCAST | IFF_SIMPLEX;
+	sc->arpcom.ac_if.if_flags = LNC_IFF_DEFAULT;
 	sc->arpcom.ac_if.if_timer = 0;
 	sc->arpcom.ac_if.if_output = ether_output;
 	sc->arpcom.ac_if.if_start = lnc_start;
@@ -1383,7 +1388,7 @@
 
 	s = splimp();
 	lnc_stop(sc);
-	sc->arpcom.ac_if.if_flags |= IFF_BROADCAST | IFF_SIMPLEX; /* XXX??? */
+	sc->arpcom.ac_if.if_flags |= LNC_IFF_DEFAULT; /* XXX??? */
 
 	/*
 	 * This sets up the memory area for the controller. Memory is set up for
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message