From owner-svn-ports-all@freebsd.org Thu Apr 12 20:02:03 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 42333F8C0EC; Thu, 12 Apr 2018 20:02:03 +0000 (UTC) (envelope-from idefix@fechner.net) Received: from anny.lostinspace.de (anny.lostinspace.de [195.30.95.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A53B48305C; Thu, 12 Apr 2018 20:02:01 +0000 (UTC) (envelope-from idefix@fechner.net) Received: from server.idefix.lan (unknown [IPv6:2a01:5c0:1e:a521:21b:21ff:fe7b:3468]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: idefix@fechner.net) by anny.lostinspace.de (Postfix) with ESMTPSA id 3D2D21142A33; Thu, 12 Apr 2018 22:01:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=fechner.net; s=default; t=1523563319; bh=el+5twewo2TMoGgcjLOvEno/6L92YKO19Rz2kVEdLjM=; h=Subject:To:References:From:Date:In-Reply-To; b=KQ25k3TC/S3AfGcwZjob0dAp64VFGDJZYj6RI41OlQQ61uDCC3nlfpgUjmiuWWQ9d Ea5RIbEzmLRDj3A2C7mrzPHLYizUXTN7FLzcZWDnV3VJeQ2zAqVW6OfthmgBGey5jt nuvm3XoqL6w1wnu3T99GNLJzxTDtavzQsjoAViOE= Received: from [192.168.0.151] (248-058-210-188.ip-addr.inexio.net [188.210.58.248]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by server.idefix.lan (Postfix) with ESMTPSA id 87B5E1511817; Thu, 12 Apr 2018 22:01:56 +0200 (CEST) Subject: Re: svn commit: r467193 - in head/www/gitlab: . files To: Sunpoet Po-Chuan Hsieh , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201804121833.w3CIXtgW077267@repo.freebsd.org> From: Matthias Fechner Openpgp: preference=signencrypt Message-ID: Date: Thu, 12 Apr 2018 22:01:48 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <201804121833.w3CIXtgW077267@repo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Apr 2018 20:02:03 -0000 Dear sunpoet, Am 12.04.2018 um 20:33 schrieb Sunpoet Po-Chuan Hsieh: > Log: > Fix Gemfile for rubygem-default_value_for 3.1.0 update > =20 > - Bump PORTREVISION for package change > > Modified: > head/www/gitlab/Makefile > head/www/gitlab/files/patch-Gemfile I really enjoy your work and it is totally fine for me, if you upgrade a gem that you copy the old one and make sure that gitlab uses the old. (like you did with r467106, thanks a lot for this!) But please do not start to patch the Gemfile! This will break gitlab. Have you tested gitlab with this modification? (for sure not, I reported exactly that version of default_value_for upstream and they rolled back the change as it broke gitlab, they broke 3.0.4 and rolled back the modification with 3.0.5, now you changed gitlab to use the version that for sure will not work!) Please revert this modification and ask me (the maintainer) before you start to modify the port I maintain. Thanks a lot that you understand this. Gru=C3=9F Matthias --=20 "Programming today is a race between software engineers striving to build bigger and better idiot-proof programs, and the universe trying to produce bigger and better idiots. So far, the universe is winning." -- Rich Cook