From owner-svn-src-head@FreeBSD.ORG  Mon Nov  3 15:51:09 2008
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from [127.0.0.1] (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by hub.freebsd.org (Postfix) with ESMTP id 4F3C6106567C;
	Mon,  3 Nov 2008 15:51:05 +0000 (UTC)
	(envelope-from jkim@FreeBSD.org)
From: Jung-uk Kim <jkim@FreeBSD.org>
To: src-committers@FreeBSD.org
Date: Mon, 3 Nov 2008 10:50:42 -0500
User-Agent: KMail/1.6.2
References: <200811021250.mA2CoGs1038957@svn.freebsd.org>
In-Reply-To: <200811021250.mA2CoGs1038957@svn.freebsd.org>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <200811031050.48765.jkim@FreeBSD.org>
Cc: svn-src-head@FreeBSD.org, Alexander Motin <mav@FreeBSD.org>,
	svn-src-all@FreeBSD.org
Subject: Re: svn commit: r184558 - head/sys/dev/acpica/Osd
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Nov 2008 15:51:09 -0000

On Sunday 02 November 2008 07:50 am, Alexander Motin wrote:
> Author: mav
> Date: Sun Nov  2 12:50:16 2008
> New Revision: 184558
> URL: http://svn.freebsd.org/changeset/base/184558
>
> Log:
>   As soon as we have several threads per process now, it is not
> correct to use process ID as ACPI thread ID. Concurrent requests
> with equal thread IDs broke ACPI mutexes operation causing
> unpredictable errors including AE_AML_MUTEX_NOT_ACQUIRED that I
> have seen.
>
>   Use kernel thread ID instead of process ID for ACPI thread.

Sorry but this patch is incorrect, i.e., td_tid is not unique.  You 
have to use curthread or (p_pid, td_tid) pair.  Unfortunately, even 
if you correct this problem, you also have to correct ACPI_THREAD_ID 
definition, which is in the vendor code.  That's why it wasn't done 
yet and it is more complicated than you think, i.e., ACPI-CA assumes 
sizeof(ACPI_THREAD_ID) == sizeof(int), etc.  Please see the related 
ACPI-CA bugs:

http://www.acpica.org/bugzilla/show_bug.cgi?id=719
http://www.acpica.org/bugzilla/show_bug.cgi?id=732

In fact, I have been maintaining patchsets with the fix here:

http://people.freebsd.org/~jkim/acpica-import-<ACPI_RELEASE>.diff.gz

Please revert this commit until we resolve these issues with the 
vendor first.

Thanks!

Jung-uk Kim