Date: Tue, 31 Jul 2012 11:27:31 -0400 From: "Jason E. Hale" <bsdkaffee@gmail.com> To: HU Dong <itechbear@gmail.com> Cc: Michael Scheidell <michael.scheidell@secnap.com>, freebsd-ports@freebsd.org Subject: Re: Problems about making a new port Message-ID: <2468689.1qABUSPjkn@mocha.verizon.net> In-Reply-To: <CAA96eVvrJScZfWBe=a4%2ByQ7WD3yh=vg80hozWX_-85cG6LRguA@mail.gmail.com> References: <CAA96eVtxj76tN3sW7zeddiy-OnvM0yVf6YLCfOt6f=gQpk6dNA@mail.gmail.com> <10338955.6OcLDV9eam@mocha.verizon.net> <CAA96eVvrJScZfWBe=a4%2ByQ7WD3yh=vg80hozWX_-85cG6LRguA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday, July 31, 2012 10:10:48 HU Dong wrote:
> As for "/usr/local/share/certs/ca-root-nss.crt", it's a cert file installed
> by security/ca_root_nss. I can't figure out how to determine its
> location automatically, but I think ${PREFIX} is not proper either, so I
> replace /usr/local with ${LOCALBASE}.
>
I've looked over this port a lot closer and it doesn't seem like this
replacement is really necessary. The user can define the location of the cert
in ~/.xombrero.conf with the ssl_ca_file variable.
> Now it seems that the only problem left is to create a wrapper script for
> the binary. I don't know where to find tutorials. Is there a google example
> that I can refer to? Roughly, I need to know where to place the original
> binary, how to name the wrapper, whether there's anything additional to do
> except copying files and executing the original binary, etc.
>
I'm not sure this is the right thing now since I looked at that script and it
requires www/get_flash_videos and multimedia/mplayer. You could make them
optional dependencies, but I wouldn't install the script to the users home
directory unless get_flash_videos and mplayer are installed. It might be
better to leave it up to the user since they will have to manually install
.xombrero.conf anyways. Maybe a pkg-message would be more appropriate.
I was bored and had some free time, so I fixed up the port and put it in my
Redports SVN repo:
https://redports.org/browser/bsdkaffee/www/xombrero
Build logs here:
https://redports.org/buildarchive/20120731145106-5752/
Clang build failed do to devel/gobject-introspection
Feel free to use any of the changes I made. Many of the changes were things I
said in my previous mail.
I did away with the do-build target and left that up to bsd.port.mk by
defining MAKE_ARGS and BUILD_WRKSRC. This will make it easier in the future
if you want to make the port use either webkit-gtk2 or webkit-gtk3 (when it
get in the ports tree). Plus we need to pass PTHREAD_CFLAGS and PTHREAD_LIBS
to make.
- Fixed some hardcoded paths and the use of -pthread directly in the Makefile.
- Added -D_GCRYPT_IN_LIBGCRYPT=1 to the Makefile to squash the warnings.
- Moved one of the reinplaces to a proper patch. Reinplaces are more for
fixing paths and multiple instances of things.
Regards,
Jason E. Hale
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2468689.1qABUSPjkn>