From owner-freebsd-net@freebsd.org Thu Mar 23 18:06:44 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EBBF0D1A2A5 for ; Thu, 23 Mar 2017 18:06:44 +0000 (UTC) (envelope-from ozkan.kirik@gmail.com) Received: from mail-qt0-x22d.google.com (mail-qt0-x22d.google.com [IPv6:2607:f8b0:400d:c0d::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A1C781515; Thu, 23 Mar 2017 18:06:44 +0000 (UTC) (envelope-from ozkan.kirik@gmail.com) Received: by mail-qt0-x22d.google.com with SMTP id r45so182331346qte.3; Thu, 23 Mar 2017 11:06:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=c3Z51nxhfSOFHIMsop6UhaPDqqAz3rqKUc21hOZn+ow=; b=s+yBBgdXM92LQMNHb/wvKDYt+6Ik2yJSigUryNKxyaAuR7xsJfoecYK0gdwC1ZzPi4 Ymhfkk/Lia1mGkTJLh4va5jvAfBpnWkKqMzrBXzptLH6g5o8mBAI4Uf9ulhYRgKCtlCy Y+/p3f8AVuA7FPKUuA8BaneUwTEsHuNl9fo60W+lq8V1e016kZj5tj06CSkMx4inpesi kkVoLLE5c7qyPJyUGKSXadbMCc/1zbOb5ACyBIGlltr5N+5loRPhxbGo/u5dxu3IqwOp gwxIgMowB2UH6wyq+q/vFrMsdPba1TZSK6CdPzg0hFvCll96Ac8vp83qESOKPLtLdObw /VXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=c3Z51nxhfSOFHIMsop6UhaPDqqAz3rqKUc21hOZn+ow=; b=axsV1AYJsPONKgVXD5j/0uTvI/raE7PUMZsqyyVPHhZHhUzlQkPSlIn9/87SFYTzIA 5uYNXcpQ23yMR0Aez0W0N+SqzPqkDvyuofGUWsr8SpisePwQ1eUuOkMa7+e9vajuq8nq VpMR/11pof8At/CdE0NKkKruGi623yiUPDN/P3rTTtbq3jAiLtcFVrZOopZLtcA30IPE RaP6e4h5CkDFPBbMoFrPYuxFHv9dypPM/oG3/XXvJaAPMcip73bJN3FiRizFcKdzIsgn PMN0NloSvEW26BxaFeUoj2JEnnTK/+dVDolP8x4ldzvBzh1vB8Y5P9+NNU/rRP/953+A CqEg== X-Gm-Message-State: AFeK/H2lQhLM4B5vS4lpvL+1k8JOzdIo7m7WnjeTSC4NB+jIvPHjMi3jYYzrA4Xsl9WMWhpfR//x/TX5q4ZmrA== X-Received: by 10.200.44.116 with SMTP id e49mr3909193qta.243.1490292403198; Thu, 23 Mar 2017 11:06:43 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.179.135 with HTTP; Thu, 23 Mar 2017 11:06:42 -0700 (PDT) In-Reply-To: References: From: =?UTF-8?B?w5Z6a2FuIEtJUklL?= Date: Thu, 23 Mar 2017 21:06:42 +0300 Message-ID: Subject: Re: if_epair altq support problem To: =?UTF-8?Q?Ermal_Lu=C3=A7i?= Cc: "freebsd-net@freebsd.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Mar 2017 18:06:45 -0000 Thank you, I'm waiting for 10.3 fix :) have a nice day On Wed, Mar 22, 2017 at 11:44 PM, Ermal Lu=C3=A7i wrote: > > On Wed, Mar 22, 2017 at 10:50 AM, =C3=96zkan KIRIK > wrote: > >> Sorry, I mistested on 10.3RELENG. >> it works on 11 RELENG, But at 10.3RELENG it throws >> >> /usr/src/sys/modules/if_epair/../../net/if_epair.c:830:2: error: >> implicit declaration of function 'if_setstartfn' is invalid in C99 >> [-Werror,-Wimplicit-function-declaration] >> >> >> On Wed, Mar 22, 2017 at 8:18 PM, =C3=96zkan KIRIK >> wrote: >> >>> Thank You Ermal ! >>> >>> It works perfectly, can you commit this patch to 11.0 RELENG and MFC to >>> 10.3 RELENG ? >>> >>> > Thanks, for confirming that it fixes your issues. > Yeah, on 10.3 its almost the same fix i will deal with it. > > >> Regards >>> >>> On Wed, Mar 22, 2017 at 6:59 AM, Ermal Lu=C3=A7i wrot= e: >>> >>>> >>>> >>>> On Tue, Mar 21, 2017 at 5:26 AM, =C3=96zkan KIRIK >>>> wrote: >>>> >>>>> Hello, >>>>> >>>>> I sent this email also to freebsd-pf list. But I think that the main >>>>> problem is belongs to sys/net/if_epair.c. >>>>> >>>>> I'm using FreeBSD 10.3-p17 amd64. epair pseudo device is listed as >>>>> supperted deviced at the Man page of altq(4). >>>>> From man page of altq : >>>>> >>>>> *SUPPORTED DEVICES >>>> >* >>>>> >>>>> The driver modifications described in altq(9) >>>>> >>>> ropos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports> >>>>> are required to use a cer- >>>>> tain network card with *ALTQ*. They have been applied to >>>>> the following >>>>> hardware drivers: ae(4) >>>>> >>>> pos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >>>>> age(4) >>>> opos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >>>>> alc(4) >>>> opos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >>>>> ale(4) >>>> opos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >>>>> an(4) >>>> pos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >>>>> ath(4) >>>> opos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >>>>> aue(4) >>>> opos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >>>>> axe(4) >>>> an.cgi?query=3Daxe&sektion=3D4&apropos=3D0&manpath=3DFreeBSD+11.0-RE >>>>> LEASE+and+Ports>, >>>>> bce(4) >>>> opos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >>>>> bfe(4) >>>> opos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >>>>> bge(4) >>>> opos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >>>>> bxe(4) >>>> opos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >>>>> cas(4) >>>> opos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >>>>> cxgbe(4) >>>> propos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >>>>> dc(4) >>>> pos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >>>>> de(4) >>>> pos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >>>>> ed(4) >>>> an.cgi?query=3Ded&sektion=3D4&apropos=3D0&manpath=3DFreeBSD+11.0-REL >>>>> EASE+and+Ports>, >>>>> em(4) >>>> pos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >>>>> ep(4) >>>> pos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >>>>> epair(4) >>>> propos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >>>>> >>>>> .... >>>>> >>>>> But while trying to use it the system says that it's not suppoerted. = I >>>>> tried on FreeBSD 11 also. The output is below: >>>>> >>>>> pf.conf : >>>>> altq on epair0b hfsc bandwidth 1Mb queue { ftp, ssh, icmp, other } >>>>> queue ftp bandwidth 30% priority 0 hfsc (upperlimit 99%) >>>>> queue ssh bandwidth 30% priority 2 hfsc (upperlimit 99%) >>>>> queue icmp bandwidth 10% priority 2 hfsc (upperlimit 99%) >>>>> queue other bandwidth 30% priority 1 hfsc (default upperlimit 99%) >>>>> >>>>> >>>>> # ifconfig epair0 create >>>>> # ifconfig epair0a up >>>>> # ifconfig epair0b up >>>>> # pfctl -f pf.conf >>>>> pfctl: epair0b: driver does not support altq >>>>> >>>>> # sysctl -a | grep ALTQ >>>>> options ALTQ_NOPCC >>>>> options ALTQ_PRIQ >>>>> options ALTQ_CDNR >>>>> options ALTQ_HFSC >>>>> options ALTQ_RIO >>>>> options ALTQ_RED >>>>> options ALTQ_CBQ >>>>> options ALTQ >>>>> >>>>> >>>>> I have a look on /usr/src/sys/net/if_epair.c, and found the ALTQ >>>>> section: >>>>> >>>>> 514 #ifdef ALTQ >>>>> 515 /* Support ALTQ via the clasic if_start() path. */ >>>>> 516 IF_LOCK(&ifp->if_snd); >>>>> 517 if (ALTQ_IS_ENABLED(&ifp->if_snd)) { >>>>> 518 ALTQ_ENQUEUE(&ifp->if_snd, m, NULL, error); >>>>> 519 if (error) >>>>> 520 ifp->if_snd.ifq_drops++; >>>>> 521 IF_UNLOCK(&ifp->if_snd); >>>>> 522 if (!error) { >>>>> 523 ifp->if_obytes +=3D len; >>>>> 524 if (mflags & (M_BCAST|M_MCAST)) >>>>> 525 ifp->if_omcasts++; >>>>> 526 >>>>> 527 if ((ifp->if_drv_flags & IFF_DRV_OACTIVE= ) >>>>> =3D=3D 0) >>>>> 528 epair_start_locked(ifp); >>>>> 529 else >>>>> 530 (void)epair_add_ifp_for_drain >>>>> ing(ifp); >>>>> 531 } >>>>> 532 return (error); >>>>> 533 } >>>>> 534 IF_UNLOCK(&ifp->if_snd); >>>>> 535 #endif >>>>> >>>>> >>>> >>>> Just apply manually this patch to make it work. >>>> >>>> diff --git a/sys/net/if_epair.c b/sys/net/if_epair.c >>>> index 540f06c..04733a5 100644 >>>> --- a/sys/net/if_epair.c >>>> +++ b/sys/net/if_epair.c >>>> @@ -827,9 +827,11 @@ epair_clone_create(struct if_clone *ifc, char >>>> *name, size_t len, caddr_t params) >>>> ifp->if_capabilities =3D IFCAP_VLAN_MTU; >>>> ifp->if_capenable =3D IFCAP_VLAN_MTU; >>>> ifp->if_start =3D epair_start; >>>> + if_setstartfn(ifp, epair_start); >>>> + if_setsendqlen(ifp, ifqmaxlen); >>>> + if_setsendqready(ifp); >>>> ifp->if_ioctl =3D epair_ioctl; >>>> ifp->if_init =3D epair_init; >>>> - ifp->if_snd.ifq_maxlen =3D ifqmaxlen; >>>> /* Assign a hopefully unique, locally administered etheraddr. = */ >>>> eaddr[0] =3D 0x02; >>>> eaddr[3] =3D (ifp->if_index >> 8) & 0xff; >>>> @@ -852,10 +854,11 @@ epair_clone_create(struct if_clone *ifc, char >>>> *name, size_t len, caddr_t params) >>>> ifp->if_flags =3D IFF_BROADCAST | IFF_SIMPLEX | IFF_MULTICAST; >>>> ifp->if_capabilities =3D IFCAP_VLAN_MTU; >>>> ifp->if_capenable =3D IFCAP_VLAN_MTU; >>>> - ifp->if_start =3D epair_start; >>>> + if_setstartfn(ifp, epair_start); >>>> + if_setsendqlen(ifp, ifqmaxlen); >>>> + if_setsendqready(ifp); >>>> ifp->if_ioctl =3D epair_ioctl; >>>> ifp->if_init =3D epair_init; >>>> - ifp->if_snd.ifq_maxlen =3D ifqmaxlen; >>>> /* We need to play some tricks here for the second interface. = */ >>>> strlcpy(name, epairname, len); >>>> error =3D if_clone_create(name, len, (caddr_t)scb); >>>> >>>> >>>> >>>> >>>> >>>>> I have no idea that why it says that it doesn't support altq altough >>>>> the >>>>> source code contains ALTQ section. >>>>> >>>>> >>>>> Regards >>>>> =C3=96zkan KIRIK >>>>> _______________________________________________ >>>>> freebsd-net@freebsd.org mailing list >>>>> https://lists.freebsd.org/mailman/listinfo/freebsd-net >>>>> To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org= " >>>> >>>> >>>> >>>> >>>> -- >>>> Ermal >>>> >>> >>> >> > > > -- > Ermal >