From owner-svn-ports-all@freebsd.org  Thu Mar  7 14:43:18 2019
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id E1DBD153150A;
 Thu,  7 Mar 2019 14:43:17 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 875BF88FD0;
 Thu,  7 Mar 2019 14:43:17 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 603791BE51; Thu,  7 Mar 2019 14:43:17 +0000 (UTC)
Date: Thu, 7 Mar 2019 14:43:17 +0000
From: Alexey Dokuchaev <danfe@freebsd.org>
To: Kyle Evans <kevans@freebsd.org>
Cc: Diane Bruce <db@freebsd.org>, svn-ports-head@freebsd.org,
 svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject: Re: svn commit: r494945 - in head/comms/wsjtx: . files
Message-ID: <20190307144317.GA13603@FreeBSD.org>
References: <201903071345.x27Dj4Gv030049@repo.freebsd.org>
 <20190307135631.GA68662@FreeBSD.org>
 <CACNAnaHaRCRc1umoj9NBbpDEwBOa=0vXRui4B8iZrKHUYZ6YjQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CACNAnaHaRCRc1umoj9NBbpDEwBOa=0vXRui4B8iZrKHUYZ6YjQ@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-Rspamd-Queue-Id: 875BF88FD0
X-Spamd-Bar: ------
Authentication-Results: mx1.freebsd.org
X-Spamd-Result: default: False [-6.85 / 15.00];
 NEURAL_HAM_MEDIUM(-1.00)[-1.000,0];
 NEURAL_HAM_SHORT(-0.85)[-0.850,0]; REPLY(-4.00)[];
 NEURAL_HAM_LONG(-1.00)[-1.000,0]
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Mar 2019 14:43:18 -0000

On Thu, Mar 07, 2019 at 08:36:25AM -0600, Kyle Evans wrote:
> On Thu, Mar 7, 2019 at 7:56 AM Alexey Dokuchaev <danfe@freebsd.org> wrote:
> >
> > On Thu, Mar 07, 2019 at 01:45:04PM +0000, Diane Bruce wrote:
> > [... snip ...]
> > > Added:
> > >   head/comms/wsjtx/files/hamlib.patch   (contents, props changed)
> > >   head/comms/wsjtx/files/wsjtx.patch   (contents, props changed)
> > > ...
> > > +post-patch:
> > > +     ${CP} ${FILESDIR}/wsjtx.patch ${WRKSRC}
> > > +     ${CP} ${FILESDIR}/hamlib.patch ${WRKSRC}
> >
> > Can't these be converted to normal patch-* files?
> >
> 
> This situation is actually a little annoying- patches of these names
> exist in the distfile that are 0-length and applied by the wsjtx build

OK, in this case I guess it can be left as is, but submitted upstream
so these hacks can be removed in the future versions of the port.

./danfe