From owner-freebsd-current  Mon Oct  2 17:07:44 1995
Return-Path: owner-current
Received: (from root@localhost)
          by freefall.freebsd.org (8.6.12/8.6.6) id RAA02419
          for current-outgoing; Mon, 2 Oct 1995 17:07:44 -0700
Received: from phaeton.artisoft.com (phaeton.Artisoft.COM [198.17.250.211])
          by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id RAA02412
          for <current@freebsd.org>; Mon, 2 Oct 1995 17:07:40 -0700
Received: (from terry@localhost) by phaeton.artisoft.com (8.6.11/8.6.9) id RAA22838; Mon, 2 Oct 1995 17:01:57 -0700
From: Terry Lambert <terry@lambert.org>
Message-Id: <199510030001.RAA22838@phaeton.artisoft.com>
Subject: Re: Another NFS server problem
To: terry@lambert.org (Terry Lambert)
Date: Mon, 2 Oct 1995 17:01:57 -0700 (MST)
Cc: current@freebsd.org
In-Reply-To: <199510022351.QAA22795@phaeton.artisoft.com> from "Terry Lambert" at Oct 2, 95 04:51:58 pm
X-Mailer: ELM [version 2.4 PL24]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Content-Length: 709       
Sender: owner-current@freebsd.org
Precedence: bulk

> 
> Apparently, nfssrv_mkdir doesn't realize that a nfs_namei with nameiop
> of CREATE causes the underlying file system to imply a SAVENAME flag
> when the terminal compoenent is reached.  Therefore a failed mkdir
> will result in a MALLOC of cn_pnbuf in nfs_namei() that is never freed.
> 
> The failure mode is triggered for a mkdir of an existing dir by a client,
> leaving the path name buffer allocated on the server.

The same failure mode exists for nfsrv_link().

> I'm very glad I'm making these side effect semantics more explicit.

Now I'm very, very glad.


					Terry Lambert
					terry@lambert.org
---
Any opinions in this posting are my own and not those of my present
or previous employers.