From owner-freebsd-hackers Sun Nov 15 11:47:34 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id LAA26002 for freebsd-hackers-outgoing; Sun, 15 Nov 1998 11:47:34 -0800 (PST) (envelope-from owner-freebsd-hackers@FreeBSD.ORG) Received: from dingo.cdrom.com (castles245.castles.com [208.214.165.245]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id LAA25991 for ; Sun, 15 Nov 1998 11:47:32 -0800 (PST) (envelope-from mike@dingo.cdrom.com) Received: from dingo.cdrom.com (LOCALHOST [127.0.0.1]) by dingo.cdrom.com (8.9.1/8.8.8) with ESMTP id LAA13781; Sun, 15 Nov 1998 11:43:10 -0800 (PST) (envelope-from mike@dingo.cdrom.com) Message-Id: <199811151943.LAA13781@dingo.cdrom.com> X-Mailer: exmh version 2.0.2 2/24/98 To: Terry Lambert cc: mike@smith.net.au (Mike Smith), grog@lemis.com, ticso@cicely.de, peter.jeremy@auss2.alcatel.com.au, hackers@FreeBSD.ORG Subject: Re: [Vinum] Stupid benchmark: newfsstone In-reply-to: Your message of "Sun, 15 Nov 1998 19:16:01 GMT." <199811151916.MAA27750@usr07.primenet.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sun, 15 Nov 1998 11:43:09 -0800 From: Mike Smith Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > > > > I'll tell you what: anybody who wants, go and look at the request > > > > building code in /usr/src/lkm/vinum/request.c and rebuild it to > > > > perform the "aggregation" optimizations that Bernd wants, and I'll > > > > put it into the code. > > > > > > RAIDFrame was built as a research tool to allow people to test > > > out just such theories, with the minimum amount of code, and no > > > modification required to the framework in which the code runs. > > > > > > It's acutally the right tool for the job of testing these ideas > > > out. > > > > ... it was also imported into NetBSD on the 12th. > > > > What's most irritating is that the vast majority of the diffs between > > the original RAIDframe code and the version imported into the NetBSD > > tree are noise - formatting, prototypes, etc. > > > > The actual meat is pretty trivial, but it makes me wonder who actually > > reviewed the code, and what their criteria were... > > Ugh. > > I know that the patch set I made was just to make the thing compile; > the author assured me that it would be rolled into the next release. > I'm not sure whether my patches on freebsd.org are redundant yet, or > not. I haven't looked at your diffs; I guess I should. > Maybe the formatting changes came from a next release of the code? Not according to the committer's website; he took the 1.1 release, bashed it sideways into the NetBSD kernel and committed it. -- \\ Sometimes you're ahead, \\ Mike Smith \\ sometimes you're behind. \\ mike@smith.net.au \\ The race is long, and in the \\ msmith@freebsd.org \\ end it's only with yourself. \\ msmith@cdrom.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message