From owner-freebsd-bugs@FreeBSD.ORG  Sun Dec 19 15:20:44 2004
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D5BEE16A567
	for <freebsd-bugs@hub.freebsd.org>;
	Sun, 19 Dec 2004 15:20:44 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B3D0243D48
	for <freebsd-bugs@hub.freebsd.org>;
	Sun, 19 Dec 2004 15:20:29 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.1/8.13.1) with ESMTP id iBJFKTxa079347
	for <freebsd-bugs@freefall.freebsd.org>; Sun, 19 Dec 2004 15:20:29 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.1/8.13.1/Submit) id iBJFKT8n079346;
	Sun, 19 Dec 2004 15:20:29 GMT
	(envelope-from gnats)
Date: Sun, 19 Dec 2004 15:20:29 GMT
Message-Id: <200412191520.iBJFKT8n079346@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Maxim Konovalov <maxim@macomnet.ru>
Subject: Re: bin/75258: [patch] dd(1) has not async signal safe interrupt
 handlers
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Maxim Konovalov <maxim@macomnet.ru>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 19 Dec 2004 15:20:45 -0000

The following reply was made to PR bin/75258; it has been noted by GNATS.

From: Maxim Konovalov <maxim@macomnet.ru>
To: "Oleg V. Nauman" <oleg@reis.zp.ua>
Cc: bug-followup@freebsd.org
Subject: Re: bin/75258: [patch] dd(1) has not async signal safe interrupt
 handlers
Date: Sun, 19 Dec 2004 18:11:06 +0300 (MSK)

 [...]
 > >Description:
 > 	dd(1) uses not safe interrupt handlers, they may leads to
 > strange problems with dd
 
 Are you sure?  Do you have a testcase?
 
 > >How-To-Repeat:
 >
 > 	man 2 sigaction
 
 Well, stdio(3) is not signal-safe in general but it seems for me
 summary() does not manipulate with the internal state of any file
 descriptors (it uses write(2)) and should be safe.
 
 Browseing the commit history says the same.
 
 [...]
 > +int need_summary;
 
 This should be volatile sig_atomic_t.
 
 -- 
 Maxim Konovalov