Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 11 Nov 2024 04:41:18 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 282687] filesystems/smbnetfs: fails to find installed libsecret dependency if libsecret-storage.so installed
Message-ID:  <bug-282687-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D282687

            Bug ID: 282687
           Summary: filesystems/smbnetfs: fails to find installed
                    libsecret dependency if libsecret-storage.so installed
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: ports-bugs@FreeBSD.org
          Reporter: jcfyecrayz@liamekaens.com

sysutils/syslog-ng installs lib/libsecret-storage.so

If that is installed when trying to build filesystems/smbnetfs, the followi=
ng
shows it fails to find the installed

=3D=3D=3D>   fusefs-smbnetfs-0.6.3_1 depends on shared library: libsecret-*=
.sotest:
/usr/local/lib/libsecret-1.so: unexpected operator
test: /usr/local/lib/libsecret-1.so: unexpected operator
 - not found

The dependency is specified in filesystems/smbnetfs/Makefile with a wildcar=
d:

LIBSECRET_LIB_DEPENDS=3D libsecret-*.so:security/libsecret

If libsecret-1.so and libsecret-storage.so are both installed, then
Mk/Scripts/find-lib.sh gets two args, and it is not prepared for that, caus=
ing
the above error.  That makes it seem like libsecret-1.so is not installed (=
even
though it is), and the build process tries to build / install libsecret aga=
in
which fails (because it is already installed).

I think it's better to be explicit and not use a wildcard in the build
dependency:

diff --git a/filesystems/smbnetfs/Makefile b/filesystems/smbnetfs/Makefile
index a577b6ece99b..5a07f103f7ea 100644
--- a/filesystems/smbnetfs/Makefile
+++ b/filesystems/smbnetfs/Makefile
@@ -16,7 +16,7 @@ OPTIONS_DEFINE=3D       DOCS LIBSECRET

 LIBSECRET_DESC=3D        Use libsecret to store credentials
 LIBSECRET_CONFIGURE_WITH=3D      libsecret
-LIBSECRET_LIB_DEPENDS=3D libsecret-*.so:security/libsecret
+LIBSECRET_LIB_DEPENDS=3D libsecret-1.so:security/libsecret

 DOCSDIR=3D       ${PREFIX}/share/doc/${PORTNAME}-${PORTVERSION}


This is the only instance of a wildcard in LIB_DEPENDS I could find in the
ports tree.  find-lib.sh admittedly should probably not fail this way (with=
 a
bourne shell parsing error), but I don't think smbnetfs should depend on ju=
st
any libsecret-*.so that happens to be installed.

--- Comment #1 from Bugzilla Automation <bugzilla@FreeBSD.org> ---
Maintainer informed via mail

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-282687-7788>