From owner-freebsd-bugs Mon Jan 26 08:54:20 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id IAA13906 for freebsd-bugs-outgoing; Mon, 26 Jan 1998 08:54:20 -0800 (PST) (envelope-from owner-freebsd-bugs@FreeBSD.ORG) Received: from alpha.xerox.com (firewall-user@alpha.Xerox.COM [13.1.64.93]) by hub.freebsd.org (8.8.8/8.8.8) with SMTP id IAA13855 for ; Mon, 26 Jan 1998 08:54:18 -0800 (PST) (envelope-from fenner@parc.xerox.com) Received: from crevenia.parc.xerox.com ([13.2.116.11]) by alpha.xerox.com with SMTP id <52348(1)>; Mon, 26 Jan 1998 08:54:04 PST Received: from localhost by crevenia.parc.xerox.com with SMTP id <177476>; Mon, 26 Jan 1998 08:53:52 -0800 To: Bruce Evans cc: freebsd-bugs@hub.freebsd.org, sprice@hiwaay.net Subject: Re: misc/1376 In-reply-to: Your message of "Mon, 26 Jan 98 06:29:38 PST." <199801261429.BAA31752@godzilla.zeta.org.au> Date: Mon, 26 Jan 1998 08:53:45 PST From: Bill Fenner Message-Id: <98Jan26.085352pst.177476@crevenia.parc.xerox.com> Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org Bruce Evans wrote: >The bzero seems to be a no-op, since tunattach() is only called once and >tunctl[] is statically initialized to 0. That was another reason that I was suspicious of the patch, but I figured I was just missing something since the PR originator seemed to think his patch fixed his problem. (Perhaps I'm making an assumption that the PR was based on having a problem as opposed to code inspection). It is clear, however, that tunattach() won't run multiple times even if it were called multiple times. Perhaps the real solution is to remove the other zero initializations to avoid confusing code inspectors. Bill