From nobody Tue Nov 25 17:14:28 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dG8SN3VLjz6HTQ7 for ; Tue, 25 Nov 2025 17:14:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dG8SN2XVMz3r9Q for ; Tue, 25 Nov 2025 17:14:28 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1764090868; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7VMAJy4HpM99nYgFeiiZ6aZoU+VWS56r7H2pQNAmf7E=; b=GEouVks66pUDfrHX9PDmPW+7UmBKZfjaU0+Etb+ZogBoVWSZEuzRYFmvc6p8H9G/so4WKV UMy5Ygqg3Y3iL1bkczuMplPw1b3S8vPxO1JTv1WWuqxcqjMuj5647rjKUHjZmkSh6q6ZWM 0M9FAUHZAcFqHHRlW60C4wzHvf1TaeWhc4/QS36smdpJ944y3J4xov4ijW2CEr+hKwVHWN 5IblAaJY4OdxwrNZR0sFgCNkIOVU/sjTVs1/IBz/X2c3YgLBw5qQ4CJsPEmecEgab7jC5C xHSnNFk/hbGavuhztOFyiv6G9O368v/q8h7FvkSDgJ1TesxA6AzoZ5rlDpQwag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1764090868; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7VMAJy4HpM99nYgFeiiZ6aZoU+VWS56r7H2pQNAmf7E=; b=yvcKdmsgqSxhbYl0twiVFcdfcVSqxGXKIttb/myDNZs1tyTDXl15s7R8TnJqIarnMXqCDU 0pFEb4RgesoEF8Tzp9l5IoKhOWNUN6rCbYTv4DA5fJG+Y7ZFwizdxhwXtwkqy96ph0ahcC uPyXukdGnH3oxZdA+vMhOUHbOAr1FYq/PzUdQ7mtLeW3fE0ejaerDK7teQeG7LkeyFRf+t ElLDvprSrktbIQoYySIZEevkLKDGExcVD/oAukqnEmxfRpAzyr4UtQOZLukO2g8Lq7jFMw kePxmKxexT1GsKJYRhTRVFnfPGTy6M0dCJQwaRhgxmeiw465U8dlC4eQBcAhzw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1764090868; a=rsa-sha256; cv=none; b=teCz7fmiikVVANlMsm45dBtYf4Lg9bqrBnRW015y+6xOTtenddP1qY9S+w4ZmwmIMeklW9 JioiLJxT1zLrMQDQae0X8Fzs7T98DDfxvUOvA0148KfRGxDkyneS1uPa8paLhB3dDWdVca VCQmrlm66VJuJV06G/hn+OkDUANkGv/1BPPAKrsW6JaHNe6SHX7Ydt7ciNj5iTue49TFgv DfOpxrWPFU2f8i5tFFBpiK6wnYeLquMCE+W0+yVHalfkd+ul/p9/INoKEL3JPGuXY2IfPw +PUDQTNzhfQgy802cn4wAf61aH6YJQ6Dke+Nn5N9jkNp/JHgfzpgODDPsps1/g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dG8SN25Kcz18Vp for ; Tue, 25 Nov 2025 17:14:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 8ba9 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 25 Nov 2025 17:14:28 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ed Maste Subject: git: fad4c92b78a1 - main - Revert "kernel linker: Disable local sym resolution by default" List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: fad4c92b78a123f87195173ac118655fa8e325cd Auto-Submitted: auto-generated Date: Tue, 25 Nov 2025 17:14:28 +0000 Message-Id: <6925e3f4.8ba9.54553559@gitrepo.freebsd.org> The branch main has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=fad4c92b78a123f87195173ac118655fa8e325cd commit fad4c92b78a123f87195173ac118655fa8e325cd Author: Ed Maste AuthorDate: 2025-11-25 17:12:36 +0000 Commit: Ed Maste CommitDate: 2025-11-25 17:14:10 +0000 Revert "kernel linker: Disable local sym resolution by default" I've received a report of a failure from resolving kern_kmq_open. Revert for now as we are currently in stabweek. This reverts commit 9562994a7aacee2baae6ddee1a7b558b48ae39ef. Reported by: mav --- UPDATING | 9 --------- sys/kern/link_elf.c | 2 +- sys/kern/link_elf_obj.c | 2 +- 3 files changed, 2 insertions(+), 11 deletions(-) diff --git a/UPDATING b/UPDATING index 7f0cb44181d3..aaef0e5b4cd3 100644 --- a/UPDATING +++ b/UPDATING @@ -27,15 +27,6 @@ NOTE TO PEOPLE WHO THINK THAT FreeBSD 16.x IS SLOW: world, or to merely disable the most expensive debugging functionality at runtime, run "ln -s 'abort:false,junk:false' /etc/malloc.conf".) -20251125: - The `debug.link_elf_leak_locals` and `debug.link_elf_obj_leak_locals` - sysctls now default to 0, so the kernel module linker no longer - performs symbol resolution against local symbols from other modules. - - If a kernel module now fails to load because of an unresolved symbol, - set these sysctls to 1 and file a bug report including details about - the affected module. - 20251115: The FreeBSD-base repository is now defined in /etc/pkg/FreeBSD.conf, disabled by default. In -CURRENT and -STABLE this points at nightly diff --git a/sys/kern/link_elf.c b/sys/kern/link_elf.c index f910fc3d5df5..ebd203858b66 100644 --- a/sys/kern/link_elf.c +++ b/sys/kern/link_elf.c @@ -203,7 +203,7 @@ static struct linker_class link_elf_class = { link_elf_methods, sizeof(struct elf_file) }; -static bool link_elf_leak_locals = false; +static bool link_elf_leak_locals = true; SYSCTL_BOOL(_debug, OID_AUTO, link_elf_leak_locals, CTLFLAG_RWTUN, &link_elf_leak_locals, 0, "Allow local symbols to participate in global module symbol resolution"); diff --git a/sys/kern/link_elf_obj.c b/sys/kern/link_elf_obj.c index 759cd75cba31..a3a53a39bfd6 100644 --- a/sys/kern/link_elf_obj.c +++ b/sys/kern/link_elf_obj.c @@ -192,7 +192,7 @@ static struct linker_class link_elf_class = { link_elf_methods, sizeof(struct elf_file) }; -static bool link_elf_obj_leak_locals = false; +static bool link_elf_obj_leak_locals = true; SYSCTL_BOOL(_debug, OID_AUTO, link_elf_obj_leak_locals, CTLFLAG_RWTUN, &link_elf_obj_leak_locals, 0, "Allow local symbols to participate in global module symbol resolution");