From owner-cvs-ports@FreeBSD.ORG  Mon Jan 19 11:04:12 2004
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id EE7CC16A4CE; Mon, 19 Jan 2004 11:04:12 -0800 (PST)
Received: from gw.celabo.org (gw.celabo.org [208.42.49.153])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 2DEF543D72; Mon, 19 Jan 2004 11:02:23 -0800 (PST)
	(envelope-from nectar@celabo.org)
Received: from madman.celabo.org (madman.celabo.org [10.0.1.111])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client CN "madman.celabo.org", Issuer "celabo.org CA" (verified OK))
	by gw.celabo.org (Postfix) with ESMTP
	id 7E7D5548A3; Mon, 19 Jan 2004 13:02:08 -0600 (CST)
Received: by madman.celabo.org (Postfix, from userid 1001)
	id 107686D455; Mon, 19 Jan 2004 13:02:07 -0600 (CST)
Date: Mon, 19 Jan 2004 13:02:07 -0600
From: "Jacques A. Vidrine" <nectar@FreeBSD.org>
To: Bruce M Simpson <bms@FreeBSD.org>
Message-ID: <20040119190207.GA54115@madman.celabo.org>
References: <200401131757.i0DHvasX096490@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200401131757.i0DHvasX096490@repoman.freebsd.org>
X-Url: http://www.celabo.org/
User-Agent: Mutt/1.5.4i-ja.1
cc: cvs-ports@FreeBSD.org
cc: edwin@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/net/tcpdump Makefile distinfo
	ports/net/tcpdump/files pkg-message-base
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Jan 2004 19:04:13 -0000

On Tue, Jan 13, 2004 at 09:57:36AM -0800, Bruce M Simpson wrote:
> bms         2004/01/13 09:57:36 PST
> 
>   FreeBSD ports repository (src committer)
> 
>   Modified files:
>     net/tcpdump          Makefile distinfo 
>   Added files:
>     net/tcpdump/files    pkg-message-base 
>   Log:
>   Update tcpdump port to latest beta with fixes for security vulnerabilities
>   in tandem with vendor branch in src tree.
>   Add an option to overwrite the base system tcpdump.
>   
>   PR:             ports/61103
>   Submitted by:   edwin

Ugh, I object to the way that ${PORTREVISION} was used here.  What
happens when the port is modified in a way such that ${PORTREVISION}
must be bumped?

 PORTNAME=      tcpdump
 PORTVERSION=   3.8.1
+PORTREVISION=  351
 CATEGORIES=    net
 MASTER_SITES=  http://www.tcpdump.org/beta/
-DISTNAME=      ${PORTNAME}-${PORTVERSION}-316
+DISTNAME=      ${PORTNAME}-${PORTVERSION}-${PORTREVISION}

Please decouple DISTNAME from PORTREVISION, but please leave
PORTREVISION at its current ridiculously high value (351), because it
cannot go backwards until PORTVERSION changes.

(IMHO, if it was really wished that the package name reflect
tcpdump.org's patch level identifier, then PORTVERSION=3.8.1.351 or
similar should have been used.)

Cheers,
-- 
Jacques Vidrine   NTT/Verio SME      FreeBSD UNIX       Heimdal
nectar@celabo.org jvidrine@verio.net nectar@freebsd.org nectar@kth.se