Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 19 Nov 2012 15:26:04 +0000 (UTC)
From:      Ed Maste <emaste@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-9@freebsd.org
Subject:   svn commit: r243282 - stable/9/sys/netinet/libalias
Message-ID:  <201211191526.qAJFQ4Xq083523@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: emaste
Date: Mon Nov 19 15:26:03 2012
New Revision: 243282
URL: http://svnweb.freebsd.org/changeset/base/243282

Log:
  MFC r241648: Avoid potential bad pointer dereference.
  
    Previously RuleAdd would leave entry->la unset for the first entry in
    the proxyList.
  
  Sponsored by: ADARA Networks

Modified:
  stable/9/sys/netinet/libalias/alias_proxy.c
Directory Properties:
  stable/9/sys/   (props changed)

Modified: stable/9/sys/netinet/libalias/alias_proxy.c
==============================================================================
--- stable/9/sys/netinet/libalias/alias_proxy.c	Mon Nov 19 15:24:19 2012	(r243281)
+++ stable/9/sys/netinet/libalias/alias_proxy.c	Mon Nov 19 15:26:03 2012	(r243282)
@@ -210,13 +210,13 @@ RuleAdd(struct libalias *la, struct prox
 
 	LIBALIAS_LOCK_ASSERT(la);
 
+	entry->la = la;
 	if (la->proxyList == NULL) {
 		la->proxyList = entry;
 		entry->last = NULL;
 		entry->next = NULL;
 		return;
 	}
-	entry->la = la;
 
 	rule_index = entry->rule_index;
 	ptr = la->proxyList;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201211191526.qAJFQ4Xq083523>