From owner-freebsd-current@freebsd.org Thu Apr 12 20:11:52 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id ACD5FF8CE94 for ; Thu, 12 Apr 2018 20:11:52 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 53035858FE; Thu, 12 Apr 2018 20:11:52 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id 04D485832; Thu, 12 Apr 2018 20:11:52 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 01226BAB; Thu, 12 Apr 2018 20:11:51 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id h6F4JoVzTtBB; Thu, 12 Apr 2018 20:11:48 +0000 (UTC) Subject: Re: Module compiles looking in /usr/src when alternate src tree is in use DKIM-Filter: OpenDKIM Filter v2.10.3 mail.xzibition.com 1A824BA6 To: "Rodney W. Grimes" , "Simon J. Gerraty" Cc: freebsd-current@freebsd.org References: <201804110029.w3B0TPUf025467@pdx.rh.CN85.dnsmgr.net> From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: <115747a8-a7f9-9112-d7b0-c4fc24742708@FreeBSD.org> Date: Thu, 12 Apr 2018 13:11:46 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <201804110029.w3B0TPUf025467@pdx.rh.CN85.dnsmgr.net> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="YRObYu5yywffVd7jj8ArloTsFLF5dYhhO" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Apr 2018 20:11:52 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --YRObYu5yywffVd7jj8ArloTsFLF5dYhhO Content-Type: multipart/mixed; boundary="ydutFZf1TmORBrV6Js8x68RbBmJQBegYC"; protected-headers="v1" From: Bryan Drewery To: "Rodney W. Grimes" , "Simon J. Gerraty" Cc: freebsd-current@freebsd.org Message-ID: <115747a8-a7f9-9112-d7b0-c4fc24742708@FreeBSD.org> Subject: Re: Module compiles looking in /usr/src when alternate src tree is in use References: <201804110029.w3B0TPUf025467@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <201804110029.w3B0TPUf025467@pdx.rh.CN85.dnsmgr.net> --ydutFZf1TmORBrV6Js8x68RbBmJQBegYC Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 4/10/2018 5:29 PM, Rodney W. Grimes wrote: >> Rodney W. Grimes wrote: >> >>> I am having a compile time issue for a patched that compiled fine on = my >>> r329294 system, but now failes to compile with what looks like a wron= g >>> header being included. >> >> You may find it helpful to do something like: >> >> make -dv -C sys/modules/vmm -V CFLAGS > /tmp/dvo 2>&1 >> egrep ':.PARSE|/usr/src/sys' /tmp/dvo | grep -B1 usr/src | more >> >> The arg to -V doesn't matter btw. >> You could narrow that down if you know what var -I/usr/src/sys is in >> (probably CFLAGS but you never know) >> the above should help find the makefile that is introducing the bogus = -I >> >=20 > Thank you, that does help narrow it down: (I backed up a vew lines > from the first place I saw src/.) >=20 > ... > Global:.PARSEFILE =3D bsd.kmod.mk > Global:.PARSEDIR =3D /usr/src-topo/share/mk > Global:.PARSEFILE =3D bsd.kmod.mk > Result[] of :U is "/usr/src/sys" > Result[] of :U is "/usr/src/sys" > Global:SYSDIR =3D ${:U/usr/src/sys:tA} > Global:.PARSEDIR =3D /usr/src-topo/share/mk > Global:.PARSEFILE =3D bsd.kmod.mk > Result[] of :U is "/usr/src/sys" > Applying[] :t to "/usr/src/sys" > Result[] of :t is "/usr/src/sys" > Result[] of :U is "/usr/src/sys" > Applying[] :t to "/usr/src/sys" > Result[] of :t is "/usr/src/sys" > Result[] of :U is "/usr/src/sys" > Applying[] :t to "/usr/src/sys" > Result[] of :t is "/usr/src/sys" > Global:.MAKE.MAKEFILES =3D /usr/src-topo/share/mk/sys.mk /usr/src-topo/= share/mk/local.sys.env.mk /usr/src-topo/share/mk/src.sys.env.mk /usr/src-= topo/share/mk/bsd.mkopt.m > k /usr/src-topo/share/mk/src.sys.obj.mk /usr/src-topo/share/mk/auto.obj= =2Emk /usr/src-topo/share/mk/bsd.suffixes.mk /usr/src-topo/share/mk/local= =2Esys.mk /usr/src-topo/sha > re/mk/src.sys.mk /usr/src-topo/sys/modules/vmm/Makefile /usr/src-topo/s= hare/mk/bsd.kmod.mk /usr/src/sys/conf/kmod.mk > = ^^^^^^^^^^^^^^^^^^^^^^^^^ > Thats gona bust something some day.... >=20 > Global:.PARSEDIR =3D /usr/src/sys/conf > Global:.PARSEFILE =3D kmod.mk > Global:.INCLUDEDFROMDIR =3D /usr/src/sys/conf > Oh my! Uggggg >=20 >=20 > So something in bsd.kmod.mk is going very wrong... it looks like it > starts to pull all sorts of stuff from /usr/src/sys! >=20 >>> >>> I have wrapped the long line so I can point to a difference between >>> r329294 and r332262 make log of this file. >>> >>> r329294 make output: >>> >>> cc -O2 -pipe -DVMM_KEEP_STATS -DSMP -fno-strict-aliasing -Werror -D= _KERNEL \ >>> -DKLD_MODULE -nostdinc -I/usr/src-topo/sys/amd64/vmm \ >>> -I/usr/src-topo/sys/amd64/vmm/io -I/usr/src-topo/sys/amd64/vmm/intel = \ >>> -I/usr/src-topo/sys/amd64/vmm/amd -I. -I/usr/src-topo/sys -fno-common= \ >>> ^^^^^^^^^^^^^^^^^ this is what= I would expect >> >> >=20 Is this buildkernel or a direct module directory build? Does reverting r331683 and r331682 help? Perhaps I missed ensuring SYSDIR is exported properly. --=20 Regards, Bryan Drewery --ydutFZf1TmORBrV6Js8x68RbBmJQBegYC-- --YRObYu5yywffVd7jj8ArloTsFLF5dYhhO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJaz72CAAoJEDXXcbtuRpfPqngIAMyPWuGDpt0bNrYu4oe8i+dg FHzod2mmtp/wDm6OTHnitXvEhk2j1Qv2gx7nTc0EZzuV7LfGi0sgJ3H7bsncKH/b DOOVPrClxr/6aCG7EDGE+IK3OjpHW9OXkmp1kmsk58WIbJHr2JCqCwh5qhulxwFK 5EaeqLmrzBDyvuubfxPqhRWjdd7fjdKD1y0wG13mUHkDHgCZXhAtmjpl/5DfOrqF W3dJCX1ChjFVVIzkokng0mxKEHEadyEHcvS54ytbquoRBdfW54W1zRhFrKB2GPPq mznrApCiH1DyQLGSEYZwInynI0VxVS3mdiByguwBoi01ehb+0CgrJBA5mNszQ1A= =f4Hx -----END PGP SIGNATURE----- --YRObYu5yywffVd7jj8ArloTsFLF5dYhhO--