From owner-freebsd-hackers@FreeBSD.ORG  Wed Sep 17 01:52:48 2003
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 1A93516A4B3; Wed, 17 Sep 2003 01:52:48 -0700 (PDT)
Received: from tide.yandex.ru (tide.yandex.ru [213.180.193.107])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 5AD4843FBF; Wed, 17 Sep 2003 01:52:47 -0700 (PDT)
	(envelope-from zevlg@yandex.ru)
Received: from YAMAIL (tide.yandex.ru) by mail.yandex.ru
	id <S571152AbTIQIwY>; Wed, 17 Sep 2003 12:52:24 +0400
Date: Wed, 17 Sep 2003 12:52:24 +0400 (MSD)
From: "lg" <zevlg@yandex.ru>
Sender: zevlg@yandex.ru
Message-Id: <3F6820C8.000001.18006@tide.yandex.ru>
MIME-Version: 1.0
X-Mailer: Yamail [ http://yandex.ru ]
Errors-To: zevlg@yandex.ru
To: Hajimu UMEMOTO <ume@FreeBSD.org>
X-source-ip: 194.226.217.217
Content-Type: text/plain;
  charset="US-ASCII"
Content-Transfer-Encoding: 7bit
cc: hackers@freebsd.org
Subject: Re: possible rijndael bug
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: zevlg@yandex.ru
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Sep 2003 08:52:48 -0000

> vlm> Absolutely NOT.

> vlm> According to RFC1423 and FIPS81, the padding length may be somewhere
> vlm> in between 1 to 16 bytes, which translated into

> vlm> 	if(padLen < 0 || padLen >= 16)

> vlm> for this particular code.

> Ah, yes.  Then, `assert(padLen > 0 && padLen <= 16)'; should be wrong.

The thing is that our padLen is not real padlen it is the (BlockSize-realpadlen), and since
BlockSize is 16 and realpadlen is in [0, 16) range(as vlm writes) than our padLen will be 
in (0, 16] range.

> Sincerely,