Date: Fri, 29 Mar 2019 19:57:57 +0000 From: Mark Linimon <linimon@lonesome.com> To: Jan Beich <jbeich@FreeBSD.org> Cc: Mark Linimon <linimon@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r497170 - in head/graphics/gstreamer1-plugins-gl: . files Message-ID: <20190329195756.GA32580@lonesome.com> In-Reply-To: <o95t-zfw4-wny@FreeBSD.org> References: <201903291721.x2THLQg3042099@repo.freebsd.org> <o95t-zfw4-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Mar 29, 2019 at 07:36:59PM +0100, Jan Beich wrote:
> Mark Linimon <linimon@FreeBSD.org> writes:
>
> > I chose a different approach from the PR. The trick is that since this
> > is a slave port, the patchdir by default is from the masterport. In my
> > fix, I put the patches back into this port's files/ subdir and do some
> > Makefile magic to invoke them.
>
> Can you provide the rationale for doing this?
To me, the other way was more confusing.
> Why indirection i.e., not ${.CURDIR}/files? ${.CURDIR} cannot be changd
> by master port.
To me, the other way was more confusing.
mcl
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190329195756.GA32580>