Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 15 Jul 2019 09:19:15 +0000
From:      Alexey Dokuchaev <danfe@freebsd.org>
To:        Gerald Pfeifer <gerald@pfeifer.com>
Cc:        Martin Matuska <mm@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r503801 - in head/graphics/exiftran: . files
Message-ID:  <20190715091915.GA83107@FreeBSD.org>
In-Reply-To: <alpine.LSU.2.21.1907150638210.4100@anthias.pfeifer.com>
References:  <201906090644.x596iCon058100@repo.freebsd.org> <20190610041555.GA98022@FreeBSD.org> <alpine.LSU.2.21.1906301741020.6112@anthias.pfeifer.com> <20190630154730.GA21108@FreeBSD.org> <alpine.LSU.2.21.1907150638210.4100@anthias.pfeifer.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jul 15, 2019 at 06:40:28AM +0200, Gerald Pfeifer wrote:
> On Sun, 30 Jun 2019, Alexey Dokuchaev wrote:
> > USES+=localbase is tycally used as a quick shortcut when you don't
> > want to create a patch or mess with sed(1) to simply teach the port
> > where to look for headers and libraries.
> 
> USES+=localbase is declarative, whereas creating a patch or messing
> with sed(1) is much more specific, so from a maintenance perspective
> the former is better.

While that's a fair point, in this case the Makefile patch already
exists for other reasons, so having another CFLAGS-related hunk won't
hurt.

In any case, CFLAGS+= line in the port's Makefile is useless, and I'm
not sure what takes Martin so long to remove it, or at least chime in
this discussion. :-)

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190715091915.GA83107>