From owner-svn-src-head@FreeBSD.ORG Mon Apr 27 18:38:55 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7186910656D2; Mon, 27 Apr 2009 18:38:55 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from cmail.optima.ua (cmail.optima.ua [195.248.191.121]) by mx1.freebsd.org (Postfix) with ESMTP id 2DD848FC1C; Mon, 27 Apr 2009 18:38:53 +0000 (UTC) (envelope-from mav@FreeBSD.org) X-Spam-Flag: SKIP X-Spam-Yversion: Spamooborona-2.1.0 Received: from [212.86.226.226] (account mav@alkar.net HELO mavbook.mavhome.dp.ua) by cmail.optima.ua (CommuniGate Pro SMTP 5.2.9) with ESMTPSA id 241397294; Mon, 27 Apr 2009 21:38:53 +0300 Message-ID: <49F5FBB8.4060607@FreeBSD.org> Date: Mon, 27 Apr 2009 21:38:48 +0300 From: Alexander Motin User-Agent: Thunderbird 2.0.0.21 (X11/20090405) MIME-Version: 1.0 To: Jung-uk Kim References: <200904271729.n3RHTpDQ021146@svn.freebsd.org> <49F5EDDD.80103@FreeBSD.org> <200904271355.43947.jkim@FreeBSD.org> In-Reply-To: <200904271355.43947.jkim@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r191568 - in head/sys/dev/ata: . chipsets X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Apr 2009 18:38:56 -0000 Jung-uk Kim wrote: > On Monday 27 April 2009 01:39 pm, Alexander Motin wrote: >> Jung-uk Kim wrote: >>> Author: jkim >>> Date: Mon Apr 27 17:29:51 2009 >>> New Revision: 191568 >>> URL: http://svn.freebsd.org/changeset/base/191568 >>> >>> Log: >>> - Always force AHCI mode on a ATI/AMD SB600/700/800 SATA >>> controller. These controllers may be configured as legacy IDE >>> mode by modifying subclass and progif without actually changing >>> PCI device IDs. Instead of complicating code, we always force >>> AHCI mode while probing. Also we restore AHCI mode while >>> resuming per ATI/AMD register programming/requirement guides. - >>> Fix SB700/800 "combined" mode. Unlike SB600, this PATA >>> controller can combine two SATA ports and emulate one PATA >>> channel as primary or secondary depending on BIOS configuration. >>> When the combined mode is disabled, this channel disappears and >>> it works just like SB600 PATA controller, however. - Add more PCI >>> device IDs for SB700/800 and adjust device descriptions. SB800 >>> shares the same PCI device IDs and added two more SATA IDs. >> Thanks. > > Thank you for answering my stupid questions! > > BTW, ATI SATA phy reset/resume requires slightly different sequence > from generic AHCI one but it just works (with little annoying timeout > message). :-) If you are talking about port 15 soft-reset timeout when port multiplier is absent, then this is known ATI controllers bug/feature. I have even added some comments in ata-ahci.c about it, but as soon as it is nonstandard and I have no respective hardware, I have left it for later. -- Alexander Motin