From owner-freebsd-current@FreeBSD.ORG Tue Aug 26 22:03:14 2014 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9EAD24B5; Tue, 26 Aug 2014 22:03:14 +0000 (UTC) Received: from mail-qg0-x233.google.com (mail-qg0-x233.google.com [IPv6:2607:f8b0:400d:c04::233]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 17C633482; Tue, 26 Aug 2014 22:03:14 +0000 (UTC) Received: by mail-qg0-f51.google.com with SMTP id a108so15220434qge.24 for ; Tue, 26 Aug 2014 15:03:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=r7GNVE8+CU3KtymSMVU1PdD982QLI1aKk4YLXMW0y2s=; b=iTx0P2DMFy0iYGbe9AEKCJqIGLWg6T3yxgbcZsDdA2nOnDTYcaomC4kCmHk9ynI7te 4zcCrS0Nj7EfTW/mVSrJVRcgQYeWz5ovyVazb9YnLKkWZXXzuwUnnr1GKsjFAJSuGs+R psVQgfurrXGUuX8QAAk22Kew70ZozTjEthoag8GUwENsHUiLCsJGyMmJf5GLHcg3iN/J pwU5H8J8wsKnO432eBro7h3DbIc/fz8qaE3PRVRdoDCSO8+7VijLoClgJBn7RnEdWJYw ErHw0rZMnCW08qYsFi/JuweZADTryzD1BF8lm/xzsT/yzkrHIQru8K98qImtiz8zXxDk Q9sA== MIME-Version: 1.0 X-Received: by 10.140.104.69 with SMTP id z63mr47369058qge.81.1409090593077; Tue, 26 Aug 2014 15:03:13 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.224.39.139 with HTTP; Tue, 26 Aug 2014 15:03:13 -0700 (PDT) In-Reply-To: References: <522300E3.6050303@rawbw.com> <2204059.7tqSNWvxzC@ralph.baldwin.cx> <201408261515.32146.jhb@freebsd.org> <20140826195140.GA10143@charmander.home> Date: Tue, 26 Aug 2014 15:03:13 -0700 X-Google-Sender-Auth: QYvLrrihXfauvkSGn4N4BOZ88Ho Message-ID: Subject: Re: [PATCH] Packet loss when 'control' messages are present with large data (sendmsg(2)) From: Adrian Chadd To: Alan Somers Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: "current@freebsd.org" , FreeBSD CURRENT , Harald Schmalzbauer , Mark Johnston , "net@freebsd.org" , Yuri X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Aug 2014 22:03:14 -0000 On 26 August 2014 14:22, Alan Somers wrote: > On Tue, Aug 26, 2014 at 1:51 PM, Mark Johnston wrote: >> On Tue, Aug 26, 2014 at 03:15:31PM -0400, John Baldwin wrote: >>> On Tuesday, August 26, 2014 11:05:12 am Alan Somers wrote: >>> > On Mon, Aug 25, 2014 at 1:52 PM, John Baldwin wrote= : >>> > > On Friday, August 22, 2014 01:34:28 PM Harald Schmalzbauer wrote: >>> > >> Bez=C3=BCglich Yuri's Nachricht vom 02.09.2013 06:54 (localtime): >>> > >> > Please check in this patch: >>> > >> > http://www.freebsd.org/cgi/query-pr.cgi?pr=3D181741 >>> > >> > Please MFC into 9.X >>> > >> > >>> > >> > Description of the problem is within PR. >>> > >> > >>> > >> > Thanks, >>> > >> > Yuri >>> > >> >>> > >> Hello, >>> > >> >>> > >> I guess this fix should make it into 10.1. >>> > >> Can someone check please? >>> > > >>> > > A fix has to make into HEAD first. I've cc'd Alan who responded to= the bug. >>> > > Alan, note that glebius@ already committed the test case to HEAD a = while ago. >>> > >>> > First, Gleb's testcase needs to be converted to ATF. This would be a >>> > good exercise for anybody who's new to ATF and wants some practice. >>> > Anybody interested? >>> >>> While that would be nice, I don't know that it's quite fair to require = the >>> test to be converted before working on a possible fix. The existing te= st >>> doesn't seem that hard to run by hand: >>> >>> % cd work/freebsd/head/tools/regression/sockets/unix_passfd/ >>> % make >>> ... >>> % > ./unix_passfd >>> beginning test1-simplesendfd >>> test1-simplesendfd passed >>> ... >>> beginning test8-rigths+creds+payload >>> unix_passfd: test8-rigths+creds+payload: recvmsg: 24 bytes received >>> >>> I only say this because in the bug followup you seemed to have describe= d a >>> possible solution so it seems that you would be able to develop a fix q= uicker >>> than other folks since you are already familiar with the issues involve= d. >>> (Also, you've fixed other related issues recently.) >> >> As it happens, I went ahead and did this anyway: >> https://reviews.freebsd.org/D689 > > BTW, is it just me, or is arcanist insanely slow? Usually "arc diff > --create" or "arc diff --update" take many minutes to complete. Like, > 30 minutes. I've been trying to do "arc patch" for nearly an hour > now, but it hasn't completed yet. It's you. it's very quick for me. -a