From owner-freebsd-git@freebsd.org Fri Apr 23 02:37:14 2021 Return-Path: Delivered-To: freebsd-git@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id ABF3D6259C6 for ; Fri, 23 Apr 2021 02:37:14 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4FRJNB3FKpz3JRR for ; Fri, 23 Apr 2021 02:37:14 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mailman.nyi.freebsd.org (Postfix) id 6CDB46259C5; Fri, 23 Apr 2021 02:37:14 +0000 (UTC) Delivered-To: git@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6B6C1625A31 for ; Fri, 23 Apr 2021 02:37:14 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FRJNB2507z3JG6; Fri, 23 Apr 2021 02:37:13 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pg1-x52f.google.com with SMTP id z16so34209760pga.1; Thu, 22 Apr 2021 19:37:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=kVZoDbF19j2QpiZTKFKRU0QOxraByooNtg70a1/AGZE=; b=JTDUZv9ATWKQTWL9UHyaI2+Azp60JWy0520yX4ilAIUA1WiJRg8RoUOjYVj+NOsMfY Zucg92Oh0rFbJPLgrYYAnGKWRClsKTth/aTLU3sSE3DeXK+GTqEII0vL+J32xMAAUI9F Tp2hPPY7eukN4xMiY03XLgqgPzDjcCByzmrD/IpvtyiX5IxET9506DT5rx3+fqEeEQhh W0DTCLC3knDY7yE+iP1Tz3Z/3ZrQzRexQrUQFgegcztBYS7PJHHB1O4IY/XKhBzUWh+b /X07GEzLkE6iZFyOuUdV3nFm2nRvjoLuwe4OZPM9dsZlSU4F6F5JssKBBwsrNYCQ6DeN V2jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :reply-to:subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=kVZoDbF19j2QpiZTKFKRU0QOxraByooNtg70a1/AGZE=; b=elycfeQDVSEqNl95ync+K/sHQVr5u9wFFS+cybiSy8IzlpKzSvhb8JsbKZ645rnK6j 6JebM0osVrl9GkfVDRGxZwUbQKVeYGIAJOIsXSx7ArtUpN060BC+0s4tS82lek73FQBp orB1idxiUrif0Qz5MXD4Ed5RRgkIk87XErBLQwXwKfCrarZ9dEH0k6EM1KqKlDeotcSO JyE8Uo6D3Ro4K7n8oSGtzIuKguLNx5N5jo+wowI/ULN0SdIFlr7gmD/OwOw1XcbjEAFV c3ImVmWWYeL5EQZaZJ5cO+enyl+ViurYdX5prf7qd8L5M37Eh7LnLjSh5XufW4W8W4dF QXHg== X-Gm-Message-State: AOAM533ihyjJvGVBFGj0azsCG0TTlwseyY2Dn9alx/RvCjrfZwiJ5V0L KGAm2vuZ7/0r2FAU7cdgBlivK/gvTbQZNqs1 X-Google-Smtp-Source: ABdhPJzp3iwVcW8XQ6FO2aPOVhtZeob+b1eWHJSXUKtdBrSolmUE0psEGAPqzG2n/nuxz1op2vAioA== X-Received: by 2002:a65:61a1:: with SMTP id i1mr1612604pgv.411.1619145432238; Thu, 22 Apr 2021 19:37:12 -0700 (PDT) Received: from [2403:5800:7500:3601:cce4:a9d1:411d:ba72] (2403-5800-7500-3601-cce4-a9d1-411d-ba72.ip6.aussiebb.net. [2403:5800:7500:3601:cce4:a9d1:411d:ba72]) by smtp.gmail.com with UTF8SMTPSA id mz20sm5936840pjb.55.2021.04.22.19.37.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Apr 2021 19:37:11 -0700 (PDT) Sender: Kubilay Kocak Message-ID: <3096b207-4468-07dd-877d-4e6d365c2e7a@FreeBSD.org> Date: Fri, 23 Apr 2021 12:37:06 +1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:90.0) Gecko/20100101 Thunderbird/90.0a1 Reply-To: koobs@FreeBSD.org Subject: Re: One surprise in commit messages with git Content-Language: en-US To: lev@FreeBSD.org, Chris Rees , Enji Cooper , Adriaan de Groot Cc: git@freebsd.org, developers@freebsd.org, Bugmeister References: <2257024.hWAQu6Pgo9@beastie.bionicmutton.org> <2fe7653d-78e8-2ca2-7508-ca6f27855bfa@FreeBSD.org> From: Kubilay Kocak In-Reply-To: <2fe7653d-78e8-2ca2-7508-ca6f27855bfa@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4FRJNB2507z3JG6 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] X-BeenThere: freebsd-git@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussion of git use in the FreeBSD project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Apr 2021 02:37:14 -0000 On 23/04/2021 6:27 am, Lev Serebryakov wrote: > On 22.04.2021 23:07, Chris Rees wrote: > >> I would suggest instead that the regex instead be "/ports >> \d\d\d\d\d+/"- this would almost eliminate false positives with >> git > > Maybe, "/\bports \d+\b/" ? > > We (bugmeister) already have this on our radar to address, and we'll come up with a scheme that suits both the historical case and most obvious current case. I believe the majority of historical refs are " r". Previous automated svn commit comments were full svn url's I replied to a post on freebsd-current (subject: linking to git revisions in bugzilla) on 12/Apr to this effect, with an 'in the meantime' recommendation, copied below: > We'll (bugmeister) be adding parsing support for it (along with a few > other related auto-linking things) > > I'd encourage people to use " " (repo = > src|doc|ports) where short hash is at least 8 chars in the meantime. > Once parsing is added all previous references will be linked. If anything needs to be tweaked post-fact (updating comments), we'll do that too. Kubilay Bugmeister