Date: Sun, 25 Dec 2022 23:19:10 +0100 From: Dimitry Andric <dim@FreeBSD.org> To: Dima Panov <fluffy@freebsd.org> Cc: "ports-committers@freebsd.org" <ports-committers@FreeBSD.org>, "dev-commits-ports-all@freebsd.org" <dev-commits-ports-all@FreeBSD.org>, "dev-commits-ports-main@freebsd.org" <dev-commits-ports-main@FreeBSD.org> Subject: Re: git: 145ca5487348 - main - audio/openal-soft: fix build with lld 15 on i386 Message-ID: <67C4B58F-2E11-4092-8757-20AC2BF28383@FreeBSD.org> In-Reply-To: <2cf7882a-a250-2c08-4434-80c836a504f8@FreeBSD.org> References: <202212251754.2BPHsgY6042846@gitrepo.freebsd.org> <2cf7882a-a250-2c08-4434-80c836a504f8@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_56180484-5CDE-4B83-A182-104641AFE5AE Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 25 Dec 2022, at 21:13, Dima Panov <fluffy@freebsd.org> wrote: >=20 > On 25.12.2022 20:54, Dimitry Andric wrote: >> The branch main has been updated by dim (src committer): >> URL: = https://cgit.FreeBSD.org/ports/commit/?id=3D145ca54873489e7d45eac99de62f73= 3a54dc294d >> commit 145ca54873489e7d45eac99de62f733a54dc294d >> Author: Dimitry Andric <dim@FreeBSD.org> >> AuthorDate: 2022-12-20 22:28:41 +0000 >> Commit: Dimitry Andric <dim@FreeBSD.org> >> CommitDate: 2022-12-25 17:53:21 +0000 >> audio/openal-soft: fix build with lld 15 on i386 >>=20 > [skip] >=20 >> +.include <bsd.port.pre.mk> >> + >> +# The following is actually meant for lld 15.0 and later, but the = ports >> +# framework does not support LINKER_TYPE and LINKER_VERSION yet. >> +.if ${COMPILER_TYPE} =3D=3D "clang" && ${COMPILER_VERSION} >=3D 150 >> +# Turn off checking of dynamic relocations, to avoid lld diagnostics = about >> +# possibly incorrect addend values. >> +LDFLAGS_i386+=3D -Wl,--no-check-dynamic-relocations >> +.endif >> + >> PLIST_SUB=3D SOVERSION=3D${PORTVERSION} >> OPTIONS_DEFINE=3D CONFIG EXAMPLES JACK OSS PORTAUDIO PULSEAUDIO \ >=20 > Looks like 1) misplased .pre.mk include and corresponding section > 2) not closed with .post.mk >=20 > This breaks OPTIONS settings (always sets to off due misconfig) and = caused unneded rebuild of consumers I'm not a ports wizard, so could you enlighten me what the correct incantation of the various *.mk files is? I.e., first bsd.port.pre.mk, then where should bsd.port.post.mk be put? The reason I put bsd.port.pre.mk there is that without it, the ports framework does not fill the COMPILER_TYPE and COMPILER_VERSION variables, even though the port Makefile has "USES=3Dcompiler". As far = as I can see in other ports Makefiles, this is solved by including bsd.port.pre.mk before the first use of those variables. -Dimitry --Apple-Mail=_56180484-5CDE-4B83-A182-104641AFE5AE Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCY6jMXgAKCRCwXqMKLiCW o2+wAKDOyxFxC4Xik52J+017pAxaesp0gwCfekdLt+chN61eUifnrZ3uGzT77gE= =4AyV -----END PGP SIGNATURE----- --Apple-Mail=_56180484-5CDE-4B83-A182-104641AFE5AE--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?67C4B58F-2E11-4092-8757-20AC2BF28383>