Date: Thu, 20 Aug 2020 21:37:04 +0000 (UTC) From: "Bradley T. Hughes" <bhughes@FreeBSD.org> To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-branches@freebsd.org Subject: svn commit: r545566 - branches/2020Q3/www/node/files Message-ID: <202008202137.07KLb4jY069553@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: bhughes Date: Thu Aug 20 21:37:04 2020 New Revision: 545566 URL: https://svnweb.freebsd.org/changeset/ports/545566 Log: MFH: r545565 www/node: build with python < 3.7 r535334 introduced a patch for tools/genv8constants.py that only worked with Python >= 3.7. The "text" argument added to Python's subprocess.Popen() is an alias for "universal_newlines", which works on all versions of Python, including 2.7. PR: 248167 Submitted by: James French <james@french.id.au> Reported by: Miroslav Lachman <000.fbsd@quip.cz> Sponsored by: Miles AS Approved by: ports-secteam (joneum) Modified: branches/2020Q3/www/node/files/patch-tools_genv8constants.py Directory Properties: branches/2020Q3/ (props changed) Modified: branches/2020Q3/www/node/files/patch-tools_genv8constants.py ============================================================================== --- branches/2020Q3/www/node/files/patch-tools_genv8constants.py Thu Aug 20 21:27:50 2020 (r545565) +++ branches/2020Q3/www/node/files/patch-tools_genv8constants.py Thu Aug 20 21:37:04 2020 (r545566) @@ -1,11 +1,11 @@ ---- tools/genv8constants.py.orig 2020-05-14 21:31:48 UTC +--- tools/genv8constants.py.orig 2020-08-20 20:43:20 UTC +++ tools/genv8constants.py @@ -20,7 +20,7 @@ if len(sys.argv) != 3: outfile = open(sys.argv[1], 'w') try: pipe = subprocess.Popen([ 'objdump', '-z', '-D', sys.argv[2] ], - bufsize=-1, stdout=subprocess.PIPE).stdout -+ bufsize=-1, stdout=subprocess.PIPE, text=True).stdout ++ bufsize=-1, stdout=subprocess.PIPE, universal_newlines=True).stdout except OSError as e: if e.errno == errno.ENOENT: print('''
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202008202137.07KLb4jY069553>