From owner-freebsd-hackers@FreeBSD.ORG  Sun Jul 30 19:30:46 2006
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
X-Original-To: freebsd-hackers@freebsd.org
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8728016A4DA
	for <freebsd-hackers@freebsd.org>; Sun, 30 Jul 2006 19:30:46 +0000 (UTC)
	(envelope-from kip.macy@gmail.com)
Received: from nz-out-0102.google.com (nz-out-0102.google.com [64.233.162.195])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1835143D46
	for <freebsd-hackers@freebsd.org>; Sun, 30 Jul 2006 19:30:46 +0000 (GMT)
	(envelope-from kip.macy@gmail.com)
Received: by nz-out-0102.google.com with SMTP id 13so97145nzn
	for <freebsd-hackers@freebsd.org>; Sun, 30 Jul 2006 12:30:45 -0700 (PDT)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com;
	h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
	b=AcmNBm7zjBxK/CyuF7mQZgJQNd7dnq83WRDJdF5RtxIKAsijGub9lKs9L4b1c8axW3MTLXaIIeMJS+CW+sfhk9JvMdxiwo9kwbJVPapsLYhS5vsIa0NxZEJqRcmnsHM//Bjy0JlfAX1PcCBIUpn8ZzPnBlmKYrFg74y+I41vQL4=
Received: by 10.65.251.1 with SMTP id d1mr1467109qbs;
	Sun, 30 Jul 2006 12:30:45 -0700 (PDT)
Received: by 10.35.16.20 with HTTP; Sun, 30 Jul 2006 12:30:45 -0700 (PDT)
Message-ID: <b1fa29170607301230u65548684ud25d77e0ff0bfb96@mail.gmail.com>
Date: Sun, 30 Jul 2006 12:30:45 -0700
From: "Kip Macy" <kip.macy@gmail.com>
To: "Tijl Coosemans" <tijl@ulyssis.org>
In-Reply-To: <200607301834.16657.tijl@ulyssis.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <200607292110.37733.tijl@ulyssis.org>
	<b1fa29170607291257h43592826j75513b465074f115@mail.gmail.com>
	<200607301834.16657.tijl@ulyssis.org>
Cc: freebsd-hackers@freebsd.org
Subject: Re: i386 page fault clobbers error code in trap frame
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: kmacy@fsmware.com
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 30 Jul 2006 19:30:46 -0000

>
> si_addr doesn't contain the faulting pc, it contains the address that

So either the comment is wrong, or that is a technically incorrect
kludge. However, given that a number of the other fields are not
filled out at all, the real objective should be to keep applications
working.

>
> --- sys/i386/i386/trap.c.orig   Sun Jul 30 18:27:21 2006
> +++ sys/i386/i386/trap.c        Sun Jul 30 18:27:56 2006
> @@ -777,9 +777,6 @@
>                 return (-1);
>         }
>
> -       /* kludge to pass faulting virtual address to sendsig */
> -       frame->tf_err = eva;
> -
>         return((rv == KERN_PROTECTION_FAILURE) ? SIGBUS : SIGSEGV);
>  }
>
>
>