From nobody Mon Jul 13 19:17:25 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gzXJ61CWRz6lgJq for ; Mon, 13 Jul 2026 19:17:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gzXJ55pBlz3T5N for ; Mon, 13 Jul 2026 19:17:25 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783970245; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lc6SA97wEeLZdvDTsRBJyRpBoS4AsZX9BAReV+0tkUU=; b=kh9BqVzDH6EOzopXE1wJEyBumjV3expAKItaaUqHqdp/fwKIk2ew0lU7daOiHN3ySEuQ4T FqfOj+ExrK63A9rXSwTSKiTXkqu9ReFPbTIURwvbB3mWh7U8jgHsObxQIGZNfepaMgfihe xccuxUDOJ7p4CGogdDmIJKYsd8dXHjElBT0BUe28vvWG2w2B+xb50Enwv4ucyXP2+9HJOG fIqd4uybg3AIqGyNv6To1B5x/tobJqF1DXk32CJteCIz9g1T9V+tceQgQ0qEttQ4uOGng+ 1Nn71Fy2ZVKBjURGmtnDkPR3gSz4oJHlxZkXN6Kqa+8bAkA5guc1BnoSjcxrWQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1783970245; a=rsa-sha256; cv=none; b=U/d9auGQCIL+KdsEdyZrq8GO9KpLth6Hzeh+Gk1vsJTuECDyeaRau2I0zHwPzoK26JvgWJ DKHr0BfvIMIkGnouwFU19Sj4rCYISraRPD0JVh2owxHsHLUBZ5ZId3SBIDXr9KEWB58mns g+6593cE+Oesyudx4G6IorPkAkEp1Ul+TDhUXTJwMRftTM3BY2mlgGBTXi2kGg1zDFhee2 4nFecYwfTktTWZiUQSvl0WnwxF/jKXuOoWN5zF7HJwDLogJI6WJk9ZTmPjX8oEXzwn95pe PJa1JhJ40CQZrSfC4Ul730px++eYXl9o1ZThl2ZDuHJgG84h1akRdW5KP/2mzg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783970245; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lc6SA97wEeLZdvDTsRBJyRpBoS4AsZX9BAReV+0tkUU=; b=v94DoVdThQW6bCIety+O86jVEz+GVse2vjNNjfsPWxcIE9sg0GnQ3AYpUAb+aQ84o1YVDD Q62O90/X6fJ2VbjHucChvxC3LNNw15lcX0vcWYo/R0vg62ZdNo16/Fl+QsVRKQV7FxTM90 FvmvvoOIjcTgeooAQhsJZCTcp20tuwtNP1ObxTBSFlZ3CIXV51mViTBF9YZ+2QBAgI5oiy OYKwVvqgpWwVBvvmv3XRAL1+FLfOJpw6qWjij3U9eV33NBW9LnnOD9ErC+WexspxIdmhlH FsGFZLgxkgq+gFEeXjJ4gz4ihWMd/tIao0qgM1ii9gt29gIiHMzhzUsrIaBXIA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gzXJ54Vjwz19yM for ; Mon, 13 Jul 2026 19:17:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 30a71 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 13 Jul 2026 19:17:25 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Toomas Soome Subject: git: 575529a92d7b - main - bhyve: unsigned <= 0 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tsoome X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 575529a92d7b35628daace82c2965984c6376e2e Auto-Submitted: auto-generated Date: Mon, 13 Jul 2026 19:17:25 +0000 Message-Id: <6a5539c5.30a71.6ea394ae@gitrepo.freebsd.org> The branch main has been updated by tsoome: URL: https://cgit.FreeBSD.org/src/commit/?id=575529a92d7b35628daace82c2965984c6376e2e commit 575529a92d7b35628daace82c2965984c6376e2e Author: Toomas Soome AuthorDate: 2026-07-13 19:15:40 +0000 Commit: Toomas Soome CommitDate: 2026-07-13 19:15:40 +0000 bhyve: unsigned <= 0 illumos smatch build is complaining: pci_nvme_parse_config() warn: 'sc->max_qentries' unsigned <= 0 pci_nvme_parse_config() warn: 'sc->ioslots' unsigned <= 0 Because we are using atoi() to translate string to int, we need to use int type variable for translation. Reviewed by: bnovkov Differential Revision: https://reviews.freebsd.org/D58213 --- usr.sbin/bhyve/pci_nvme.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/usr.sbin/bhyve/pci_nvme.c b/usr.sbin/bhyve/pci_nvme.c index 7e6c8bc9d719..3656ee7a8d65 100644 --- a/usr.sbin/bhyve/pci_nvme.c +++ b/usr.sbin/bhyve/pci_nvme.c @@ -3167,6 +3167,7 @@ pci_nvme_parse_config(struct pci_nvme_softc *sc, nvlist_t *nvl) char bident[sizeof("XXX:XXX")]; const char *value; uint32_t sectsz; + int val; sc->max_queues = NVME_QUEUES; sc->max_qentries = NVME_MAX_QENTRIES; @@ -3183,20 +3184,21 @@ pci_nvme_parse_config(struct pci_nvme_softc *sc, nvlist_t *nvl) sc->max_queues = atoi(value); value = get_config_value_node(nvl, "qsz"); if (value != NULL) { - sc->max_qentries = atoi(value); - if (sc->max_qentries <= 0) { - EPRINTLN("nvme: Invalid qsz option %d", - sc->max_qentries); + val = atoi(value); + if (val <= 0) { + EPRINTLN("nvme: Invalid qsz option %d", val); return (-1); } + sc->max_qentries = val; } value = get_config_value_node(nvl, "ioslots"); if (value != NULL) { - sc->ioslots = atoi(value); - if (sc->ioslots <= 0) { - EPRINTLN("Invalid ioslots option %d", sc->ioslots); + val = atoi(value); + if (val <= 0) { + EPRINTLN("Invalid ioslots option %d", val); return (-1); } + sc->ioslots = val; } value = get_config_value_node(nvl, "sectsz"); if (value != NULL)