From owner-freebsd-usb@freebsd.org  Wed Sep 27 06:35:27 2017
Return-Path: <owner-freebsd-usb@freebsd.org>
Delivered-To: freebsd-usb@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7400DE2C76F
 for <freebsd-usb@mailman.ysv.freebsd.org>;
 Wed, 27 Sep 2017 06:35:27 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from mail.turbocat.net (turbocat.net [IPv6:2a01:4f8:c17:6c4b::2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 3C80A65F33;
 Wed, 27 Sep 2017 06:35:27 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from hps2016.home.selasky.org (unknown [62.141.129.119])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id EE82E2601AB;
 Wed, 27 Sep 2017 08:35:24 +0200 (CEST)
Subject: Re: USB/U3G: Added support for Panasonic CF-F9 GOBI 3G modem to U3G
 module
To: Ian Lepore <ian@freebsd.org>, Tomasz CEDRO <tomek@cedro.info>,
 "freebsd-usb@FreeBSD.org" <freebsd-usb@freebsd.org>
References: <CAFYkXjnF+wkrxNC6nf9s20AytVkszykEcPsr=roiaYugAo5YWg@mail.gmail.com>
 <ec4baec2-66a9-c5ce-eb89-01f553890a11@selasky.org>
 <1506465459.73082.168.camel@freebsd.org>
From: Hans Petter Selasky <hps@selasky.org>
Message-ID: <165556bc-c011-bebd-feee-5bbd4cb5943e@selasky.org>
Date: Wed, 27 Sep 2017 08:32:52 +0200
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <1506465459.73082.168.camel@freebsd.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-BeenThere: freebsd-usb@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: FreeBSD support for USB <freebsd-usb.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-usb>,
 <mailto:freebsd-usb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-usb/>
List-Post: <mailto:freebsd-usb@freebsd.org>
List-Help: <mailto:freebsd-usb-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
 <mailto:freebsd-usb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Sep 2017 06:35:27 -0000

On 09/27/17 00:37, Ian Lepore wrote:
> On Wed, 2017-09-27 at 00:30 +0200, Hans Petter Selasky wrote:
>> On 09/27/17 00:11, Tomasz CEDRO wrote:
>>>
>>> https://github.com/freebsd/freebsd/pull/115
>>>
>>> :-)
>>>
>> The devd.conf rule should match more than just vendor and product:
>>
>>
>> +# Load GOBI 2000/3000 U3G QDL modem firmware on attach / boot.
>> +# Note: This requires additional "gobi_loader" utility to be
>> installed,
>> +#   as well as valid QDL driver firmware files placed in
>> /boot/firmware/gobi.
>> +#   If modem does not accept valid firmware try gobi_loader -2000
>> switch.
>> +#   Please adjust modem VID/PID to match your device supported by
>> u3g
>> module.
>> +#attach 100 {
>> +#	match "vendor" "0x04da";
>> +#	match "product" "0x250e";
>> +#	action "/usr/local/sbin/gobi_loader /dev/cuaU0
>> /boot/firmware/gobi/";
>> +#};
>>
>> Else patch looks good.
>>
>> --HPS
> 
> Hard-coding /dev/cuaU0 cannot possibly be right.
> 
> -- Ian
> 

These three lines are missing:

         match "system"          "DEVFS";
         match "subsystem"       "CDEV";
         match "type"            "CREATE";


--HPS