From owner-freebsd-bugs@FreeBSD.ORG Sun Feb 3 06:18:54 2013 Return-Path: Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 959B6DB3 for ; Sun, 3 Feb 2013 06:18:54 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com [209.85.217.182]) by mx1.freebsd.org (Postfix) with ESMTP id 192E68A9 for ; Sun, 3 Feb 2013 06:18:53 +0000 (UTC) Received: by mail-lb0-f182.google.com with SMTP id gg6so5799897lbb.13 for ; Sat, 02 Feb 2013 22:18:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=x-received:mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=1UxrhLKhN3s6MwscmojaHq8idy3ZGm7qU8YcI5J1R6Y=; b=BcnltwA2lpwvW63QhNZjOhXrL36fezIT7eyNRhH7eY+PE+c3M3nqPBg90zs2lodVQs xz0btjxpZMhlbv02a1vGk2oP1BHy6Y6j794t2BQlpqQsIpvimbF5h3ueibv2cCwRu2NN QLfckw+ArNBN+drzn+DTVvM8yOletNNQV4B+Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type:x-gm-message-state; bh=1UxrhLKhN3s6MwscmojaHq8idy3ZGm7qU8YcI5J1R6Y=; b=LAL2zhYoAj2MG3MjPcODwVyYtfE4WrNmflK8JRoumb8CpesRUNPNJEJ/a1SJejdH0v tSHu4cajwpeYeaVzUEaJwNI7wwl4guJHLvzIhnGipgsHWdPNGVWC4S7cDi2o19l91CIF ++yvEu4NE7mJTeIjf3BYUJhKGjXidEesIsQwc0PLSVoa61uweKaGKa78eKqg/DfJrAZY q0e66SAjRSLfM1+sBHFRvfqgzzQgyGPkUvKywpRybl2ODITcsJ8+7Tdiwrtj9mByC978 DiE1dlZui7NqLi5ZDxUgw6U086rCjxrB5YVjlcZKe4cy8gkCPJJv0U4JdNWdnRWEx9un zwqg== X-Received: by 10.112.17.137 with SMTP id o9mr6840415lbd.15.1359872327117; Sat, 02 Feb 2013 22:18:47 -0800 (PST) MIME-Version: 1.0 Received: by 10.112.91.164 with HTTP; Sat, 2 Feb 2013 22:18:17 -0800 (PST) In-Reply-To: <201302030530.r135U1HP013561@freefall.freebsd.org> References: <201302030530.r135U1HP013561@freefall.freebsd.org> From: Eitan Adler Date: Sun, 3 Feb 2013 01:18:17 -0500 Message-ID: Subject: Re: kern/175674: sem_open() should use O_EXLOCK with open() instead of a separate flock() call To: Giorgos Keramidas Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQnCbLbbxuBP3El3n7jZIJoIY5QHipSyHwY5uhYIY0TD9gtHZRshYrYnRl+DL1dyHex4kl6G Cc: freebsd-bugs@freebsd.org, bug-followup X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Feb 2013 06:18:54 -0000 On 3 February 2013 00:30, Giorgos Keramidas wrote: > Jilles and David, do you think this patch looks ok for libc? Why bother keeping the contents of the #if 0? Remove it. Then it looks good to me. -- Eitan Adler