From owner-freebsd-current@FreeBSD.ORG Fri May 27 15:46:35 2011 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 364C3106566C for ; Fri, 27 May 2011 15:46:35 +0000 (UTC) (envelope-from pluknet@gmail.com) Received: from mail-qw0-f54.google.com (mail-qw0-f54.google.com [209.85.216.54]) by mx1.freebsd.org (Postfix) with ESMTP id E0C4A8FC0A for ; Fri, 27 May 2011 15:46:34 +0000 (UTC) Received: by qwc9 with SMTP id 9so1265237qwc.13 for ; Fri, 27 May 2011 08:46:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=RevPjH34vjhtxNFI5zxHMBLyTdm0/kAUilqj2YTdD9Q=; b=FkWhbTU5gOzdGT7rYQZCh5gkDFoFVO3pLgX3gSnGyxZi8MnoMB/Cn838x9x59TdqVg yC2iCS6ZDxysvk+647DwCPoyeKe9LyrqlCbO3uPL2ejyFnfjljDL47FEqkg8KyDcLr9F ljX9au6B+4XU08E8AO5wVUQkPVUQ0jmxZJe4g= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=qTkl+8NZESdUxjcS4eScT3CV6XC7dUFEYWpmU3EVhoa2oeRsv8LVUpTNdWo0is3UE7 XvPVrvp+S//N+iKg/1NCZeNW+RxKfLgeHR6rqdEiGCltb/aNwkjQHREHbU3CsvgO+l7Q uHSB1xgf1HNmGpV8/EqcWOq/tGcPTncCy6Oy0= MIME-Version: 1.0 Received: by 10.229.119.151 with SMTP id z23mr1655413qcq.2.1306509478659; Fri, 27 May 2011 08:17:58 -0700 (PDT) Received: by 10.229.86.133 with HTTP; Fri, 27 May 2011 08:17:58 -0700 (PDT) In-Reply-To: <201105271046.30379.jhb@freebsd.org> References: <201105271046.30379.jhb@freebsd.org> Date: Fri, 27 May 2011 19:17:58 +0400 Message-ID: From: Sergey Kandaurov To: John Baldwin Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: current@freebsd.org Subject: Re: [PATCH] Toggle display of the kernel idle process (per-CPU idle threads) in top X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 May 2011 15:46:35 -0000 On 27 May 2011 18:46, John Baldwin wrote: > Some times in top, I don't want to see all the per-CPU idle threads but > instead focus on the non-idle threads that are running. =A0Especially on = a > system with a lot of CPUs, the idle threads can push all the interesting > threads off of the list. =A0This patch adds a new 'z' flag (gratuitously = chosen > letter) and interactive command to toggle the display of the system idle > process. =A0Patch is tested against 8, but should work fine on HEAD too: Works on HEAD as well. I like this idea. Perhaps it could be combined with i key? > @@ -1075,7 +1081,13 @@ > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0reset_disp= lay(); > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0putchar('\= r'); > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0break; > - > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 case CMD_kidletog: > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ps.kidle = =3D !ps.kidle; > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 new_message= (MT_standout | MT_delayed, > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 " %= sisplaying kernel idle process.", > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ps.= idle ? "D" : "Not d"); ^^ typo: s/idle/kidle/ --=20 wbr, pluknet