Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 08 Dec 2021 09:00:45 +0000
From:      bugzilla-noreply@freebsd.org
To:        bugs@FreeBSD.org
Subject:   [Bug 260068] e1000 & igb in netmap mode removes VLAN headers
Message-ID:  <bug-260068-227-vBmoIB7F8W@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-260068-227@https.bugs.freebsd.org/bugzilla/>
References:  <bug-260068-227@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D260068

--- Comment #10 from commit-hook@FreeBSD.org ---
A commit in branch main references this bug:

URL:
https://cgit.FreeBSD.org/src/commit/?id=3De0f4cdba533693bb6ef9d90243acdad89=
605b150

commit e0f4cdba533693bb6ef9d90243acdad89605b150
Author:     Vincenzo Maffione <vmaffione@FreeBSD.org>
AuthorDate: 2021-12-08 08:55:04 +0000
Commit:     Vincenzo Maffione <vmaffione@FreeBSD.org>
CommitDate: 2021-12-08 08:55:40 +0000

    e1000: fix interface capabilities management

    The e1000 drivers (em, lem, igb) are currently looking at the
    iflib copies of the capabilities bitvectors (scctx->isc_capabilities
    and scctx->isc_capenable) rather than the ifnet ones
    (ifp->if_capabilities and ifp->if_capenable). However, the latter
    are the ones that are actually updated by ifconfig and that should
    be used by the drivers during interface operation. The former are
    set by the driver on interface attach (for iflib internal use)
    and should not be used anymore by the driver.
    This patch fixes the e1000 driver to use the correct bitvectors.

    PR:             260068
    Reviewed by:    markj
    MFC after:      2 weeks
    Differential Revision:  https://reviews.freebsd.org/D33154

 sys/dev/e1000/if_em.c | 42 +++++++++++++++++++++++-------------------
 1 file changed, 23 insertions(+), 19 deletions(-)

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-260068-227-vBmoIB7F8W>