From owner-freebsd-ports-bugs@FreeBSD.ORG  Fri May  5 06:39:48 2006
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
X-Original-To: freebsd-ports-bugs@FreeBSD.org
Delivered-To: freebsd-ports-bugs@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9FD5916A40E
	for <freebsd-ports-bugs@FreeBSD.org>;
	Fri,  5 May 2006 06:39:48 +0000 (UTC)
	(envelope-from herve.quiroz@esil.univ-mrs.fr)
Received: from arabica.esil.univ-mrs.fr (arabica.esil.univ-mrs.fr
	[139.124.41.108])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0B4E943D46
	for <freebsd-ports-bugs@FreeBSD.org>;
	Fri,  5 May 2006 06:39:47 +0000 (GMT)
	(envelope-from herve.quiroz@esil.univ-mrs.fr)
Received: from arabica.esil.univ-mrs.fr (localhost [127.0.0.1])
	by arabica.esil.univ-mrs.fr (8.13.4/8.13.4) with ESMTP id
	k456dfDg058726; Fri, 5 May 2006 08:39:41 +0200 (CEST)
	(envelope-from herve.quiroz@esil.univ-mrs.fr)
Received: (from rv@localhost)
	by arabica.esil.univ-mrs.fr (8.13.6/8.13.6/Submit) id k456dfRl058725;
	Fri, 5 May 2006 08:39:41 +0200 (CEST)
	(envelope-from herve.quiroz@esil.univ-mrs.fr)
X-Authentication-Warning: arabica.esil.univ-mrs.fr: rv set sender to
	herve.quiroz@esil.univ-mrs.fr using -f
Date: Fri, 5 May 2006 08:39:41 +0200
From: Herve Quiroz <herve.quiroz@esil.univ-mrs.fr>
To: Jean-Baptiste Quenot <jbq@caraldi.com>
Message-ID: <20060505063941.GA52984@arabica.esil.univ-mrs.fr>
References: <200605021342.k42DgUdx059526@freefall.freebsd.org>
	<20060504091154.GD68374@vision.anyware>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20060504091154.GD68374@vision.anyware>
User-Agent: Mutt/1.4.2.1i
Cc: freebsd-ports-bugs@FreeBSD.org
Subject: Re: ports/96659: [PATCH] devel/maven: Improve launcher shell script
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 05 May 2006 06:39:48 -0000

On Thu, May 04, 2006 at 11:11:55AM +0200, Jean-Baptiste Quenot wrote:
> Patch  approved working!   But I  wouldn't have  forked the  shell
> script... this  will be  difficult to  maintain when  changes come
> from upstreams.

I just thought there were too many changes do apply to the original
launcher and too much unused code (cygwin/MacOS stuff) that we could
have our own one.

But in case you prefer to stay with the original launcher, maybe we
could consider another approach by having the default JAVA_HOME,
MAVEN_OPTS and MAVEN_HOME set via /etc/mavenrc (although I would prefer
${PREFIX}/etc/mavenrc in such case)...

Herve