From owner-cvs-src@FreeBSD.ORG Sat Jul 9 00:49:48 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3C89416A41C; Sat, 9 Jul 2005 00:49:48 +0000 (GMT) (envelope-from trhodes@FreeBSD.org) Received: from pittgoth.com (14.zlnp1.xdsl.nauticom.net [209.195.149.111]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4314043D45; Sat, 9 Jul 2005 00:49:46 +0000 (GMT) (envelope-from trhodes@FreeBSD.org) Received: from mobile.pittgoth.com (ip68-105-180-53.dc.dc.cox.net [68.105.180.53]) (authenticated bits=0) by pittgoth.com (8.13.3/8.13.3) with ESMTP id j690ngFe066378 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 8 Jul 2005 20:49:42 -0400 (EDT) (envelope-from trhodes@FreeBSD.org) Date: Fri, 8 Jul 2005 20:48:44 -0400 From: Tom Rhodes To: "M. Warner Losh" Message-ID: <20050708204844.7372b288@mobile.pittgoth.com> In-Reply-To: <20050708.152823.132414307.imp@bsdimp.com> References: <200507081837.j68Ib0IM082223@repoman.freebsd.org> <42CECCD8.5070201@portaone.com> <42CEEF12.4070904@samsco.org> <20050708.152823.132414307.imp@bsdimp.com> X-Mailer: Sylpheed-Claws 1.0.1 (GTK+ 1.2.10; i386-portbld-freebsd6.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: rik@FreeBSD.org, scottl@samsco.org, src-committers@FreeBSD.org, cvs-src@FreeBSD.org, sobomax@portaone.com, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/compat/ndis subr_ntoskrnl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Jul 2005 00:49:48 -0000 On Fri, 08 Jul 2005 15:28:23 -0600 (MDT) "M. Warner Losh" wrote: > In message: <42CEEF12.4070904@samsco.org> > Scott Long writes: > : Maxim Sobolev wrote: > : > Roman Kurakin wrote: > : > > : >> rik 2005-07-08 18:36:59 UTC > : >> > : >> FreeBSD src repository > : >> > : >> Modified files: > : >> sys/compat/ndis subr_ntoskrnl.c Log: > : >> Use implicit type cast for ->k_lock to fix compilation of ndis > : >> as a part of the GENERIC kernel with INVARIANT* and WITNESS* > : >> turned off. > : > > : > > : > I think the better fix is to change type of k_lock member from void* to > : > the struct mtx*, I've already commited such change to the RELENG_5 few > : > days ago. > : > > : > -Maxim > : > : It's a void* for portability with other OS's. This work has already > : been ported > : to Solaris, and maybe even other OS's by now. Reducing the portability is a > : bad idea, and will likely get you smacked around by Bill when he > : notices. I'd > : highly recommend not doing this again in the future. > > And once Bill gets done with you, Paul will have his turn :-) > > Warner > > (If that doesn't get me smacked, I don't know what will) > /me offers his paddle to whoever will play the punishment executioner. -- Tom Rhodes