Date: Mon, 26 Apr 1999 16:00:01 -0700 (PDT) From: Chris Piazza <cpiazza@home.net> To: freebsd-ports@FreeBSD.org Subject: Re: ports/11328: Upgrade x11-toolkits/fltk Message-ID: <199904262300.QAA08243@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/11328; it has been noted by GNATS.
From: Chris Piazza <cpiazza@home.net>
To: freebsd-gnats-submit@freebsd.org, dima@Chg.RU
Cc:
Subject: Re: ports/11328: Upgrade x11-toolkits/fltk
Date: Mon, 26 Apr 1999 15:53:01 -0700 (PDT)
First off let me say that I recognize that Dima is the maintainer for this
port, but I am somewhat puzzled by some changes.
If I'm off base please let me know.
First:
@@ -20,23 +20,22 @@
LIB_DEPENDS= MesaGL.14:${PORTSDIR}/graphics/Mesa3
-USE_BZIP2= yes
Now, isn't it policy to use BZIP2 where possible if it decreases the
filesize?
(from ftp.fltk.org)
-r--r--r-- 1 root sys 964877 Apr 24 03:38 fltk-1.0.2-source.tar.bz2
-r--r--r-- 1 root sys 1092094 Apr 24 03:33 fltk-1.0.2-source.tar.gz
Second:
+.if OBJFORMAT=="elf"
+BROKEN= Due to ELF library format
.endif
Erm... I tested this myself and this port does work on an ELF system (4.0-C).
This was axed.
Third:
post-install:
- ${SETENV} OBJFORMAT=${PORTOBJFORMAT} ${LDCONFIG} -m ${PREFIX}/lib
- ${INSTALL_MAN} ${WRKSRC}/documentation/fluid.1 \
- ${PREFIX}/man/man1
+ @ ${LDCONFIG} -m ${PREFIX}/lib
Besides the addition of many extra tabs in this makefile, this doesn't seem
right. I quote from http://www.freebsd.org/handbook/porting.html:
The ldconfig line in Makefiles should read:
${SETENV} OBJFORMAT=${PORTOBJFORMAT} ${LDCONFIG} -m ....
In PLIST it should read;
@exec /usr/bin/env OBJFORMAT=%%PORTOBJFORMAT%% /sbin/ldconfig -m ...
@unexec /usr/bin/env OBJFORMAT=%%PORTOBJFORMAT%% /sbin/ldconfig -R
I have changed all of these and attached the updated port below.
NOTE:
pkg/PLIST.nodocs was removed.
--Cut--
Index: fltk/Makefile
===================================================================
RCS file: /cvs/FreeBSD/ports/x11-toolkits/fltk/Makefile,v
retrieving revision 1.4
diff -u -r1.4 Makefile
--- Makefile 1999/04/16 06:15:09 1.4
+++ Makefile 1999/04/26 22:28:55
@@ -1,16 +1,16 @@
# New ports collection makefile for: fltk
-# Version required: 1.0.1
+# Version required: 1.0.2
# Date created: 11 February 1999
# Whom: Dima Sivachenko <dima@Chg.RU>
#
# $Id: Makefile,v 1.4 1999/04/16 06:15:09 taoka Exp $
#
-DISTNAME= fltk-1.0.1-source
-PKGNAME= fltk-1.0.1
+DISTNAME= fltk-1.0.2-source
+PKGNAME= fltk-1.0.2
CATEGORIES= x11-toolkits
MASTER_SITES= ftp://ftp.fltk.org/pub/fltk/${VERSION}/ \
- ftp://ftp.easysw.com/pub/fltk/${VERSION}/ \
+ ftp://ftp.chg.ru/pub/X11/fltk/${VERSION}/ \
ftp://ftp2.easysw.com/pub/fltk/${VERSION}/ \
ftp://ftp.northamerica.net/pub/ESP/fltk/${VERSION}/ \
ftp://ftp.funet.fi/mirrors/ftp.easysw.com/pub/fltk/${VERSION}/ \
@@ -26,17 +26,13 @@
CONFIGURE_ENV= CXXFLAGS="${CFLAGS}"
WRKSRC= ${WRKDIR}/${PKGNAME}
USE_X_PREFIX= yes
-MAN1= fluid.1
-VERSION= 1.0.1
+MAN1= fluid.1
+VERSION= 1.0.2
-.if defined(NOPORTDOCS)
-PLIST= ${PKGDIR}/PLIST.nodocs
-.endif
-
post-install:
- ${SETENV} OBJFORMAT=${PORTOBJFORMAT} ${LDCONFIG} -m ${PREFIX}/lib
- ${INSTALL_MAN} ${WRKSRC}/documentation/fluid.1 \
- ${PREFIX}/man/man1
+ @ ${SETENV} OBJFORMAT=${PORTOBJFORMAT} ${LDCONFIG} -m ${PREFIX}/lib
+ @ ${INSTALL_MAN} ${WRKSRC}/documentation/fluid.1 \
+ ${PREFIX}/man/man1
.if !defined(NOPORTDOCS)
@ ${MKDIR} ${PREFIX}/share/doc/fltk
@ ${INSTALL_DATA} ${WRKSRC}/documentation/*.html \
Index: fltk/files/md5
===================================================================
RCS file: /cvs/FreeBSD/ports/x11-toolkits/fltk/files/md5,v
retrieving revision 1.2
diff -u -r1.2 md5
--- md5 1999/04/16 06:15:09 1.2
+++ md5 1999/04/26 22:35:19
@@ -1 +1 @@
-MD5 (fltk-1.0.1-source.tar.bz2) = 0604cf4e6c53802dda52035ccc97c631
+MD5 (fltk-1.0.2-source.tar.bz2) = da05fc3adbf0ecffcfe79a3ed3c2ec98
Index: fltk/pkg/PLIST
===================================================================
RCS file: /cvs/FreeBSD/ports/x11-toolkits/fltk/pkg/PLIST,v
retrieving revision 1.2
diff -u -r1.2 PLIST
--- PLIST 1999/04/16 06:15:10 1.2
+++ PLIST 1999/04/26 22:27:42
@@ -189,7 +189,7 @@
lib/libfltk.a
lib/libfltk.so
lib/libfltk.so.1
-@exec /usr/bin/env OBJFORMAT=%%PORTOBJFORMAT%% /sbin/ldconfig -m %B
+@exec /usr/bin/env OBJFORMAT=%%PORTOBJFORMAT%% /sbin/ldconfig -m %D/lib
@unexec /usr/bin/env OBJFORMAT=%%PORTOBJFORMAT%% /sbin/ldconfig -R
share/doc/fltk/FL.gif
share/doc/fltk/Fl_Adjuster.html
@@ -322,5 +322,5 @@
share/doc/fltk/value_slider.gif
share/doc/fltk/widgets.html
@dirrm include/FL
-@unexec rmdir %D/include/Fl 2>/dev/null || true
+include/Fl
@dirrm share/doc/fltk
--Cut--
---
Chris Piazza Abbotsford, BC, Canada
cpiazza@home.net
finger norn@norn.ca.eu.org for PGP key
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199904262300.QAA08243>