Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 12 Sep 2021 08:37:59 GMT
From:      Daniel Engberg <diizzy@FreeBSD.org>
To:        ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org
Subject:   git: fb6ad88501bf - main - audio/tagutil: Rework Makefile to follow Porter's Handbook
Message-ID:  <202109120837.18C8bxLE035187@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by diizzy:

URL: https://cgit.FreeBSD.org/ports/commit/?id=fb6ad88501bf6d3d8ff5f768a4f2e35182e8e44c

commit fb6ad88501bf6d3d8ff5f768a4f2e35182e8e44c
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2021-09-12 08:26:53 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2021-09-12 08:34:39 +0000

    audio/tagutil: Rework Makefile to follow Porter's Handbook
    
    PR:             258351
    Reviewed by:    Alexandre Perrin (maintainer)
    Approved by:    tcberner (mentor)
    Differential Revision:  https://reviews.freebsd.org/D31912
---
 audio/tagutil/Makefile | 43 ++++++++++++++++++++++---------------------
 1 file changed, 22 insertions(+), 21 deletions(-)

diff --git a/audio/tagutil/Makefile b/audio/tagutil/Makefile
index 3df658e2ddcf..2656e7176fbe 100644
--- a/audio/tagutil/Makefile
+++ b/audio/tagutil/Makefile
@@ -1,47 +1,48 @@
 PORTNAME=	tagutil
-PORTVERSION=	3.1
 DISTVERSIONPREFIX=	v
+DISTVERSION=	3.1
 CATEGORIES=	audio
 
 MAINTAINER=	alex@kaworu.ch
 COMMENT=	Command line interface tool to manage tags in music files
 
 LICENSE=	BSD2CLAUSE
-
-BROKEN_riscv64=		fails to link: cannot open /nxb-bin/usr/lib/clang/11.0.0/lib/freebsd/libclang_rt.ubsan_standalone-riscv64.a: No such file or directory
+LICENSE_FILE=	${WRKSRC}/LICENSE
 
 LIB_DEPENDS=	libyaml.so:textproc/libyaml
 
+USES=		cmake compiler:c++11-lang iconv pkgconfig
+
 USE_GITHUB=	yes
 GH_ACCOUNT=	kAworu
 
-USES=		cmake compiler:c++11-lang iconv pkgconfig
-PLIST_FILES=	bin/tagutil \
-		man/man1/tagutil.1.gz
-
 CMAKE_ARGS=	-DMAN_PATH=${PREFIX}/man
 CMAKE_SOURCE_PATH=	${WRKSRC}/src
 
-OPTIONS_DEFINE=	JSON
-OPTIONS_MULTI=	MEDIA
+LDFLAGS_FreeBSD_11=	-fuse-ld=lld
+LDFLAGS+=	${LDFLAGS_${OPSYS}_${OSREL:R}}
+
+PLIST_FILES=	bin/tagutil \
+		man/man1/tagutil.1.gz
+
+OPTIONS_DEFINE=		JSON
+OPTIONS_MULTI=		MEDIA
 OPTIONS_MULTI_MEDIA=	FLAC OGG TAGLIB
 OPTIONS_DEFAULT=	FLAC OGG TAGLIB
-TAGLIB_DESC=	Multiple file format but limited tags support
-JSON_DESC=	JSON output format support
+
+TAGLIB_DESC=		Multiple file format but limited tags support
 
 JSON_LIB_DEPENDS=	libjansson.so:devel/jansson
-JSON_CMAKE_OFF=	-DWITHOUT_JSON=yes
+JSON_CMAKE_OFF=		-DWITHOUT_JSON=yes
+
 FLAC_LIB_DEPENDS=	libFLAC.so:audio/flac
-FLAC_CMAKE_OFF=	-DWITHOUT_FLAC=yes
-OGG_LIB_DEPENDS=\
-	libvorbisfile.so:audio/libvorbis \
-	libogg.so:audio/libogg
-OGG_CMAKE_OFF=	-DWITHOUT_OGGVORBIS=yes
+FLAC_CMAKE_OFF=		-DWITHOUT_FLAC=yes
+
+OGG_LIB_DEPENDS=	libvorbisfile.so:audio/libvorbis \
+			libogg.so:audio/libogg
+OGG_CMAKE_OFF=		-DWITHOUT_OGGVORBIS=yes
+
 TAGLIB_LIB_DEPENDS=	libtag_c.so:audio/taglib
 TAGLIB_CMAKE_OFF=	-DWITHOUT_TAGLIB=yes
-# For FreeBSD 11: ld: undefined reference to symbol `__cxa_demangle@@CXXABI_1.3' (try adding -lcxxrt)
-.if exists(/usr/bin/ld.lld) && ${/usr/bin/ld:L:tA} != /usr/bin/ld.lld
-TAGLIB_LDFLAGS=		-fuse-ld=lld
-.endif
 
 .include <bsd.port.mk>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202109120837.18C8bxLE035187>