From nobody Tue Apr 9 22:06:02 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VDg5W2JYSz5G6kK; Tue, 9 Apr 2024 22:06:07 +0000 (UTC) (envelope-from tijl@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VDg5W1mC4z3xZG; Tue, 9 Apr 2024 22:06:07 +0000 (UTC) (envelope-from tijl@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1712700367; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7RXGavdR9fuMfCesC5SGm9l6heV1nniJSv8JLTUaRB8=; b=QosbQMEiv7duTSUoMXjEnu/T8HWoxLtppvo8UOYLl8SuqYsO+alxodad6AIBL6e3WfI6eA X3W3SCHIxMsddwNIVFPPyFw5QZesKsDALN4l0YjAx6xQEyfjxKWBEoo+zTrkHMakyS9yGV j4rveCRUaEjoryaPNALlkyAEQ1Jih/CDZItBJTNBmRRGjuUq8CfPmqcOy8jEkWX9BYPdnP R8OEyKRf74b1VwdhkCD/PtSQaUokq/iaSVx1W+YHTXNWnGIvQjp2ssbwq9ht2hUlTlyk2Y DK7wQQbHt52euoct6rLhzW27v3F+7KBX9af0O75VsnN0FKQX4GdL/ZTWYJ0Taw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1712700367; a=rsa-sha256; cv=none; b=haLS9474WUNEbXU0PQQ0Si5vBzEv8a/10da4CEF6mH1ijAzz1CTqUOdl35sARL9zwHa7wr m0OOhGDONV2Rxoth9tpdXZZTRCl3W8EQqx5lRIQmivRin8k560hBpb+TnDnDbOw6abLM48 IGc6C1kLGK4avslci5P5z41/elGHTJ1W9tIFzZ3fYjpdjbC/7MZXe/KfJxlFlhbXWrWw5i F+9PN4P9CrKEMTpuSp3MnWCjkxjHOy53nU8sUcGWx2KgtCWr/NoZDqOY9ucF2nDT+xl65c UGuAm6x0vY6MMXe2CTBvsgUfea48+TgMkRyEWtT5DRJL1sycVeru9js/dI5bZg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1712700367; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7RXGavdR9fuMfCesC5SGm9l6heV1nniJSv8JLTUaRB8=; b=m4yj0PMK6wDlzrJeFsKpSZiqy10tIziKs46usLooTAed8ex56FQMrtrXuHaMxWbPYJfAmQ kMZGLQu0BzCIdHpaD0gzrL8gxO0B+vkXwAAxUDuu9AwNXxKazz7rgXCElGOlUbdDvig9oR Us1DqxGMCaZM7oPsmgHuK9EJ17orwNQNsL7+VwJUM3wQTQZ6whSUk1Q+mTPj7vRHd3yNuo iJ3/+w1ddw9KzISAUQWvcbbIbyE7gmHRQXKOERJCGCwCf9vK6dSgNXwQqenae52Qt+mRYB SaYejBIaVZCgiKP32pShU0Ue/Kofl6DVlZmIF92/oIBoh2+sjH/YazALh53L1Q== Received: from hal.tijl.coosemans.org (unknown [IPv6:2a02:a03f:994e:2800:9f9:1983:93e6:62ec]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: tijl) by smtp.freebsd.org (Postfix) with ESMTPSA id 4VDg5V4MHWz1Hmp; Tue, 9 Apr 2024 22:06:06 +0000 (UTC) (envelope-from tijl@FreeBSD.org) Date: Wed, 10 Apr 2024 00:06:02 +0200 From: =?UTF-8?B?VMSzbA==?= Coosemans To: Po-Chuan Hsieh Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: cc9c37d73947 - main - */*: Always use WRK_ENV with SETENVI Message-ID: <20240410000602.7450c54d@hal.tijl.coosemans.org> In-Reply-To: References: <202403231747.42NHlaRh091094@gitrepo.freebsd.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: dev-commits-ports-main+owner@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, 9 Apr 2024 05:15:22 +0800 Po-Chuan Hsieh wrote: > Hello Tijl, >=20 > On Sun, Mar 24, 2024 at 1:47=E2=80=AFAM Tijl Coosemans = wrote: >=20 >> The branch main has been updated by tijl: >> >> URL: >> https://cgit.FreeBSD.org/ports/commit/?id=3Dcc9c37d73947e0184f66f0b5fa3f= c021f7fdf51c >> >> commit cc9c37d73947e0184f66f0b5fa3fc021f7fdf51c >> Author: Tijl Coosemans >> AuthorDate: 2024-03-23 17:35:13 +0000 >> Commit: Tijl Coosemans >> CommitDate: 2024-03-23 17:45:45 +0000 >> >> */*: Always use WRK_ENV with SETENVI >> >> WRK_ENV contains environment variables like OSVERSION and UNAME_* th= at >> are needed when cross-building packages using Poudriere for a differ= ent >> version of FreeBSD or a different architecture than that of the host >> system. =20 >=20 >=20 > It's just my 2 cents. >=20 > If SETENVI and WRK_ENV always come together, it would be better to have a > new knob for it (e.g. SET_BASIC_ENV, SET_COMMON_ENV or SET_MIN_ENV). > Therefore we won't use only part of them. The side benefit is it's > shorter. Sure, no objection. Maybe make it even shorter, e.g. DO_WRK. SETENVI and WRK_ENV don't always go together. There are a few existing cases of ${SETENV} -i in the tree that could be replaced with ${SETENVI} without ${WRK_ENV}. > Since WRK_ENV contains a minimal set of common environment variables, > could we rename it to a more intuitive name such as COMMON_ENV or > something like that? It's called WRK_ENV because it's tied to WRKDIR. It should be used to run upstream commands/scripts in WRKDIR and only for that purpose. Also, it won't necessarily stay minimal. There's quite a bit of duplication between CONFIGURE_ENV and MAKE_ENV much of which could be moved to WRK_ENV.