From owner-dev-commits-src-all@freebsd.org Sun Jan 10 12:59:11 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 210ED4CB956; Sun, 10 Jan 2021 12:59:11 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DDH3M05dHz4c65; Sun, 10 Jan 2021 12:59:11 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "R3" (verified OK)) (Authenticated sender: dim) by smtp.freebsd.org (Postfix) with ESMTPSA id CF77A25864; Sun, 10 Jan 2021 12:59:10 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from [IPv6:2001:470:7a58::1d5d:d377:dcb4:cd20] (unknown [IPv6:2001:470:7a58:0:1d5d:d377:dcb4:cd20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id AD9DE42214; Sun, 10 Jan 2021 13:59:08 +0100 (CET) From: Dimitry Andric Message-Id: <2B913109-27A8-4ABF-8F64-48CE78B76759@FreeBSD.org> Content-Type: multipart/signed; boundary="Apple-Mail=_B662E377-B892-42B0-A9EE-915CA5C94CBD"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\)) Subject: Re: git: 6733401935f8 - main - nvmecontrol: add device self-test op and log page Date: Sun, 10 Jan 2021 13:59:02 +0100 In-Reply-To: <202101082253.108MrrUL003251@slippy.cwsent.com> Cc: Chuck Tuffli , Jessica Clarke , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" , "src-committers@freebsd.org" To: Cy Schubert References: <202101081729.108HTG7j066884@gitrepo.freebsd.org> <74314BD0-A0F8-481A-93A0-28FB83CB2717@freebsd.org> <202101081920.108JKUd2003299@slippy.cwsent.com> <202101081927.108JRKxR084004@slippy.cwsent.com> <202101082253.108MrrUL003251@slippy.cwsent.com> X-Mailer: Apple Mail (2.3445.104.17) X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Jan 2021 12:59:11 -0000 --Apple-Mail=_B662E377-B892-42B0-A9EE-915CA5C94CBD Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 8 Jan 2021, at 23:53, Cy Schubert wrote: >=20 > In message = om> > , Chuck Tuffli writes: >> --000000000000c9481f05b86a0c60 >> Content-Type: text/plain; charset=3D"UTF-8" >>=20 >> On Fri, Jan 8, 2021 at 11:27 AM Cy Schubert = >> wrote: >>=20 >>> In message <202101081920.108JKUd2003299@slippy.cwsent.com>, Cy = Schubert >>> writes: >>>> In message <74314BD0-A0F8-481A-93A0-28FB83CB2717@freebsd.org>, = Jessica >>>> Clarke w >>>> rites: >>>=20 >> ... >>=20 >>>>> This broke powerpc and powerpc64: >>=20 >>=20 >> Sorry about that. I'll fix this in a bit. >>=20 >> --chuck >=20 > Looks like dim@ already did. >=20 > The time before last I fixed one of these it was pointed out to me > privately that when we use %jd that we should also cast to intmax_t or > uintmax_t, and that jhb@ told him. This was to future-proof, assuming = we'd > have 128-bit processors one day. That is certainly valid for e.g. time_t or other types with a varying width, or where you cannot predict the exact width. But for printing uint64_t and friends, where the width *is* exactly specified, I would rather just use the standards-defined PRIu64 and so on. Casting will obscure any type mismatches between the printf format strings and the actual arguments. -Dimitry --Apple-Mail=_B662E377-B892-42B0-A9EE-915CA5C94CBD Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCX/r6FgAKCRCwXqMKLiCW o+J+AKCeYyD2580Oi4rzzHPSGP87XkiNcACfRsz+iNOqMwrRN1jtksK75qLGIWA= =VpgJ -----END PGP SIGNATURE----- --Apple-Mail=_B662E377-B892-42B0-A9EE-915CA5C94CBD--