From owner-svn-src-head@freebsd.org Mon Dec 30 22:39:29 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A8D951EC295; Mon, 30 Dec 2019 22:39:29 +0000 (UTC) (envelope-from rmacklem@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47msmx3zMlz4Z5t; Mon, 30 Dec 2019 22:39:29 +0000 (UTC) (envelope-from rmacklem@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 7F4FA8BE5; Mon, 30 Dec 2019 22:39:29 +0000 (UTC) (envelope-from rmacklem@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id xBUMdTqZ021437; Mon, 30 Dec 2019 22:39:29 GMT (envelope-from rmacklem@FreeBSD.org) Received: (from rmacklem@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id xBUMdTli021436; Mon, 30 Dec 2019 22:39:29 GMT (envelope-from rmacklem@FreeBSD.org) Message-Id: <201912302239.xBUMdTli021436@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: rmacklem set sender to rmacklem@FreeBSD.org using -f From: Rick Macklem Date: Mon, 30 Dec 2019 22:39:29 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r356210 - head/sys/nfs X-SVN-Group: head X-SVN-Commit-Author: rmacklem X-SVN-Commit-Paths: head/sys/nfs X-SVN-Commit-Revision: 356210 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Dec 2019 22:39:29 -0000 Author: rmacklem Date: Mon Dec 30 22:39:29 2019 New Revision: 356210 URL: https://svnweb.freebsd.org/changeset/base/356210 Log: Add warning printf w.r.t. removal of sys/nfs/nfs_lock.c. The code in sys/nfs/nfs_lock.c has not been run by default since March 2008 when it was replaced by the in kernel sys/nlm code. It uses Giant, so it needs to be removed before the FreeBSD 13 release. This will happen in a couple of months, since few if any users run the code anyhow and can easily switch to the default in kernel NFSLOCKD. Modified: head/sys/nfs/nfs_lock.c Modified: head/sys/nfs/nfs_lock.c ============================================================================== --- head/sys/nfs/nfs_lock.c Mon Dec 30 22:05:57 2019 (r356209) +++ head/sys/nfs/nfs_lock.c Mon Dec 30 22:39:29 2019 (r356210) @@ -89,6 +89,8 @@ nfslock_open(struct cdev *dev, int oflags, int devtype { int error; + printf("WARNING: uses Giant and will be removed before FreeBSD 13\n" + "\tuse the kernel NFSLOCKD/nfslockd.ko\n"); error = priv_check(td, PRIV_NFS_LOCKD); if (error) return (error);